perf(ZipOpenFS): replace FILE_PARTS_REGEX with indexOf implementation #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
findZipinsideZipOpenFSisn't as fast as it can be because we use a regexp to extract the archive part from paths.How did you fix it?
By using an
indexOf-based implementation that is 3.7x faster.Profiled on the Storybook repo (lockfile only install):
337.0 ms(spent executing the regexp)89.2 ms(spent insidegetArchivePart)I haven't tested how much it improves PnP runtime's perf, but it would be interesting to see. 🤔
Checklist