Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(node-modules): remove redundant semver instance from bundle #2881

Merged
merged 2 commits into from
May 12, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 11, 2021

What's the problem this PR addresses?

There is an instance of semver@^6.0.0 in the CLI that we don't need as it's just used to check if node is >= 10.12.0

$ yarn why semver -R
[...]
├─ @yarnpkg/plugin-node-modules@workspace:packages/plugin-node-modules
│  ├─ @zkochan/cmd-shim@npm:4.3.0 (via npm:^4.3.0)
│  │  └─ make-dir@npm:3.1.0 (via npm:^3.0.0)

How did you fix it?

Update @zkochan/cmd-shim which removes the version of make-dir that drags in semver@^6.0.0

 Bundle size
- 1 999 317 bytes
+ 1 978 490 bytes

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from larixer May 11, 2021 20:34
@larixer larixer merged commit 5d2a73b into master May 12, 2021
@larixer larixer deleted the merceyz/perf/nm-cmd-shim branch May 12, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants