build: improve tree shaking #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Dec 1, 2021
Comment on lines
12
to
16
| treeshake: { | ||
| propertyReadSideEffects: false, | ||
| unknownGlobalSideEffects: false, | ||
| tryCatchDeoptimization: false, | ||
| }, |
There was a problem hiding this comment.
I'm worried about those, as it would be a massive pain to debug any issue they could accidentally cause. The gain seems fairly low, so I'd tend to favour long-term maintainability.
merceyz
force-pushed
the
merceyz/chore/improve-tree-shaking
branch
from
5c40c94 to
c5d2f9d
Compare
|
Tests show something broke |
|
Seems to be rollup/rollup#4195, fixed by updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Rollup is preserving code that could possibly have side effects but we know doesn't.es5code.How did you fix it?
Enable more aggressive tree shaking.es2015code.Result
Tested on this repo
$ du -sb ./.pnp-* 2665838 ./.pnp-after.cjs 2670400 ./.pnp-before.cjsChecklist