Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): typescript - handle files not covered by pnp #3817

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Nov 29, 2021

What's the problem this PR addresses?

#3297 (specifically merceyz/TypeScript@88a1059) broke auto import in hybrid PnP and node_modules projects.

Fixes #3816

How did you fix it?

Handle findPnpApi not returning a pnpapi (merceyz/TypeScript@20ffca2)

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/fix/typescript-hybrid-pnp-nm branch from 73a064e to b815d09 Compare December 2, 2021 13:32
@merceyz merceyz force-pushed the merceyz/fix/typescript-hybrid-pnp-nm branch from b815d09 to 3a816b6 Compare December 2, 2021 16:39
@arcanis arcanis merged commit 3bf7ea3 into master Dec 3, 2021
@arcanis arcanis deleted the merceyz/fix/typescript-hybrid-pnp-nm branch December 3, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: vscode autoimport not working with pnpIgnorePatterns
2 participants