Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(libui): update ink #6524

Merged
merged 6 commits into from
Oct 1, 2024
Merged

chore(libui): update ink #6524

merged 6 commits into from
Oct 1, 2024

Conversation

BasixKOR
Copy link
Contributor

@BasixKOR BasixKOR commented Sep 26, 2024

What's the problem this PR addresses?

While working on a yarn plugin (internal one), I noticed one of the yarn packages had unmet peer dependencies.

➤ YN0000: @yarnpkg/plugin-interactive-tools@npm:4.0.0 [ae217] provides react@npm:16.14.0 with version 16.14.0, which doesn't satisfy the following requirements:

➤ YN0000: ink@npm:3.2.0 [64b23]                                          → >=16.8.0 ✓
➤ YN0000: react-reconciler@npm:0.26.2 [57218] → ^17.0.2  ✘

➤ YN0000: Note: these requirements start with ink@npm:3.2.0 [64b23]

This happened because inside Yarn, ink's resolution is fixed due to the patches to reduce the lodash size.

...

How did you fix it?

This PR updates the libraries to the closet matching major version, removing the peer errrors.

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 33f249b into yarnpkg:master Oct 1, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants