-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a patchfile for fsevents #692
Conversation
Could you get the PR to our fsevents repo? We will discuss it there! |
Though I have to say that fsevents seems like the worst possible layer to do this. |
Damn, for some reasons |
Oh interesting - FSEvents 2.x works on GitHub Actions, but not 1.x 🤔 |
Errata: I had a typo in the variable name that was causing |
Merging for now, will open a PR against FSEvents later. |
Waiting for copy-aragon-ui-assets to be compatible with PnP. Also waiting for the next yarn version to be released to get this fix: yarnpkg/berry#692 Alternatively, we could upgrade react-scripts.
Waiting for copy-aragon-ui-assets to be compatible with PnP. Also waiting for the next yarn version to be released to get this fix: yarnpkg/berry#692 Alternatively, we could upgrade react-scripts.
What's the problem this PR addresses?
FsEvents isn't aware of the virtual filesystem (
$$virtual
, more details at the end of this post), and that breaks Webpack when requiring files from a workspace that lists peer dependencies.How did you fix it?
As a short-term fix I've implemented the fix in
fsevents
via our newpatch:
protocol. I wonder if we could convince thefsevents
maintainers to merge the change upstream? (cc @paulmillr / @pipobscure)What is this
$$virtual
thing?First read that. Now, as the article says:
The way we do this by injecting a
fs
layer that applies the following algorithm:/$$virtual/<whatever>/<number>/
'../'.repeat(number)
So for example,
/foo/$$virtual/abcdef/0/hello
becomes/foo/hello
, and/foo/$$virtual/abcdef/1/hello
becomes/hello
. This technic allows us to generate an infinity of paths for a given package.