Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias system #65

Closed
wants to merge 3 commits into from
Closed

add alias system #65

wants to merge 3 commits into from

Conversation

voxsim
Copy link

@voxsim voxsim commented May 14, 2017

After digging in many issues of the yarn project, I think we should do something like this!

Let me know if you like the idea ;)

@bestander
Copy link
Member

Not a huge fan, I think modern shell interpreters can fill this niche without any change needed in Yarn.

@gsklee
Copy link

gsklee commented May 22, 2017

This can be done in shell fairly easily: http://stackoverflow.com/questions/7131670/make-a-bash-alias-that-takes-a-parameter

@voxsim
Copy link
Author

voxsim commented May 22, 2017

Yep I know, but before closing this pr, I think we should decide some things:

  • We now have a bunch of unsopported aliases, maybe we should delete that part (https://github.com/yarnpkg/yarn/blob/master/src/cli/unsupported-aliases.js) because it gives confusion in some way
  • We sometime use ls, rm for some commands, maybe we should use always the long version and deprecate the short one. This is always for consistency.
  • We should close all the issue related to alias something and tell everyone that we don't want to support this and I am ok with that, I can do without any problems :)

Let me know what you think ;)

@gsklee
Copy link

gsklee commented May 22, 2017

Yeah, basically what we need is some valiant soul willing to do the triage works to clean things up a bit :p

@bestander
Copy link
Member

bestander commented May 22, 2017

I've put the next 2 weeks for issue triaging, this task is there for coordination yarnpkg/yarn#3474, please join me any time you feel like it.
Just comment on the issue if you want to claim a chunk of 10-20 issues to look through and triage them.
If you don't have permissions use me as a bot by cc-ing me with a command.

The goal is to get ALL issues under control, prioritize and fix the ones critical for 1.0 release.

@bestander
Copy link
Member

Back to this PR, I vote to remove the aliases and educate people to create their own aliases for their workflows

@gsklee
Copy link

gsklee commented May 22, 2017

Probably also wanna add a list of popular feature requests that have been discussed thoroughly and rejected into the issue template of either the main repo or this one.

@bestander
Copy link
Member

As for education, anyone, send a blog post entry here https://github.com/yarnpkg/website/tree/master/_posts how people can add aliases for their favorite operating system using Yarn

@gsklee
Copy link

gsklee commented Jun 18, 2017

@bestander Finally got the time... once the blog post is accepted this RFC can be resolved I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants