-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests cleanup: reenabled test, removed npm from CI commands (#1692)
* enabled install-import-pr-2, this feature has been implemented * a better test fix
- Loading branch information
Showing
9 changed files
with
11 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,4 +55,4 @@ os: | |
#- osx | ||
- linux | ||
|
||
script: npm run $TEST_TYPE | ||
script: yarn $TEST_TYPE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -238,8 +238,7 @@ test.concurrent('add with new dependency should be deterministic', (): Promise<v | |
}); | ||
}); | ||
|
||
// TODO https://github.com/facebook/yarn/issues/79 | ||
xit('add with new dependency should be deterministic 2', (): Promise<void> => { | ||
test.concurrent('add with new dependency should be deterministic 2', (): Promise<void> => { | ||
// [email protected]>[email protected] is saved in local mirror and is deduped | ||
// install [email protected] should replace [email protected] in root | ||
|
||
|
@@ -275,7 +274,8 @@ xit('add with new dependency should be deterministic 2', (): Promise<void> => { | |
|
||
const lockFileWritten = await fs.readFile(path.join(config.cwd, 'yarn.lock')); | ||
const lockFileLines = explodeLockfile(lockFileWritten); | ||
assert.equal(lockFileLines.length, 8); | ||
// see why we don't cleanup lockfile https://github.com/yarnpkg/yarn/issues/79 | ||
assert.equal(lockFileLines.length, 11); | ||
|
||
const mirror = await fs.walk(path.join(config.cwd, mirrorPath)); | ||
assert.equal(mirror.length, 3); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -538,8 +538,8 @@ test.concurrent('install should respect --no-bin-links flag', (): Promise<void> | |
}); | ||
|
||
|
||
xit('install should update a dependency to yarn and mirror (PR import scenario 2)', (): Promise<void> => { | ||
// [email protected] is saved in local mirror and gets updated to [email protected] via | ||
test.concurrent('install should update a dependency to yarn and mirror (PR import scenario 2)', (): Promise<void> => { | ||
// [email protected] is gets updated to [email protected] via | ||
// a change in package.json, | ||
// files in mirror, yarn.lock, package.json and node_modules should reflect that | ||
|
||
|
Empty file.
Binary file removed
BIN
-19.4 KB
__tests__/fixtures/install/install-import-pr-2/mirror-for-offline/mime-db-1.0.3.tgz
Binary file not shown.
Binary file removed
BIN
-2.25 KB
__tests__/fixtures/install/install-import-pr-2/mirror-for-offline/mime-types-2.0.0.tgz
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters