Add --version flag to install script
#1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to renaming the install script (since it no longer installs the latest), but didn't want to make such a sweeping change yet. |
Daniel15
reviewed
Nov 18, 2016
| @@ -107,16 +109,24 @@ yarn_install() { | |||
|
|
|||
| if [ -d "$HOME/.yarn" ]; then | |||
| if [ -n `which yarn` ]; then | |||
| local SPECIFIED_VERSION | |||
| local VERSION_TYPE | |||
There was a problem hiding this comment.
Why do you use local for these but latest_url doesn't use it?
There was a problem hiding this comment.
Totally forgot about it, good catch!
Daniel15
reviewed
Nov 18, 2016
| if [ "$1" = '--nightly' ]; then | ||
| latest_url=https://nightly.yarnpkg.com/latest-tar-version | ||
| SPECIFIED_VERSION=`curl $latest_url` |
There was a problem hiding this comment.
Please use lowercase for variables (I know, I messed this up in some files, I need to fix it 😛 ). Apparently uppercase is generally only used for environment variables.
|
This is awesome! Thank you! |
Daniel15
approved these changes
Nov 18, 2016
naganowl
added a commit
to naganowl/website
that referenced
this pull request
Nov 18, 2016
Document how to use the changes per yarnpkg/yarn#1928
Daniel15
pushed a commit
to yarnpkg/website
that referenced
this pull request
Nov 18, 2016
…273) * Add docs for using the `--version` flag with the installation script Document how to use the changes per yarnpkg/yarn#1928 * Actually pass arguments to the script rather than curl
lovelypuppy0607
added a commit
to lovelypuppy0607/website
that referenced
this pull request
May 11, 2023
…(#273) * Add docs for using the `--version` flag with the installation script Document how to use the changes per yarnpkg/yarn#1928 * Actually pass arguments to the script rather than curl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a --version flag to the installation script, expanding on the nightly flag added in #1554. When provided, the script will download the specified build of Yarn, rather than the stable released version. It grabs them from the downloads directory as specified in #1724 (comment) and updates the version check to reflect if the user has installed the same version (regardless of flags provided) in the user's home directory. The speed of this script is ~1 minute faster compared to using
npmand provides an alternative to switching versions to help with #1724 as well.Test plan
./install-latest.shgets latest release version (0.16.1),./install-latest.sh --nightlygets latest nightly build (0.18.0-20161117.1624 right now),./install-latest.sh --version 0.17.4installs0.17.4.