Prevents the link: protocol from crashing when no package.json is used #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
yarnpkg#7337) * Stops reading the manifest for link: dependencies * Prevents crashing when the package.json doesnt exist
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
yarnpkg#7337) * Stops reading the manifest for link: dependencies * Prevents crashing when the package.json doesnt exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current code tries to read the manifest when possible, and fallback to a dummy object otherwise. This behavior is problematic (we should never read from the local manifest, as that makes the exact behavior change depending on the state of the repository), but we won't be able to change it in the 1.x (it will however behave as I described in the 2.x, thanks to the split between
link:andportal:).Test plan
Tests should still pass.