Include remote address string in Request, Call #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbbit
reviewed
Mar 18, 2024
jquirke
force-pushed
the
addremoteaddress
branch
4 times, most recently
from
762f458 to
a40f5f4
Compare
jquirke
force-pushed
the
addremoteaddress
branch
from
a40f5f4 to
ed49714
Compare
biosvs
reviewed
Apr 9, 2024
biosvs
reviewed
Apr 9, 2024
biosvs
reviewed
Apr 9, 2024
biosvs
reviewed
Apr 9, 2024
jquirke
force-pushed
the
addremoteaddress
branch
from
b95c4d0 to
7154419
Compare
This allows the application to log the remote address for a connection. It is primarily aimed at debugging and audit use cases. One can imagine it can be injected to a logging context, for example. e.g. ``` peerAddrPort := yarpc.CallFromContext(ctx).CallerPeerAddrPort().String() ```
jquirke
force-pushed
the
addremoteaddress
branch
from
7154419 to
2ed706c
Compare
|
Hey @jquirke, is this feature is still needed, or you already solved your task with another approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow peer address to be accessible to the server handler function as per #2252
This allows the server and middleware to access the underlying peer connection address in a transport agnostic way. Middleware and the server handler can then utilise this to implement audit, logging (debug), various host based rate limiting, etc.
e.g. Server RPC handler
e.g. Middleware