Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some issues in yast2-cluster write function #110

Open
wants to merge 1 commit into
base: SLE-15-SP3
Choose a base branch
from
Open

There are some issues in yast2-cluster write function #110

wants to merge 1 commit into from

Conversation

varkoly
Copy link
Contributor

@varkoly varkoly commented Aug 11, 2023

https://bugzilla.suse.com/show_bug.cgi?id=1209602

There are some issues in yast2-cluster write function

  1. Instead of csync2.socket csymc2.service will be actiwated which does not exists.
  2. After Writing corosync confiugration Write(path, nil) will not be called. This causes that the corosync configuration will not be written inmediately bug only after the module is closed. This is especially a problem if the module is loaded from another module via the import function.
  3. /etc/sysconfig/openais does not exists anymore. In code this agent will be called, which causes error logs. The corresponding SCR agent need to be removed.

Solution

  • Remove sensless call to sysconfig.openais
  • Remove sensless sysconfig.openais agent
  • Enable csync2.socket
  • Add SCR.Write(PATH,nil) to save the configuration inmediately

nstead of csync2.socket csymc2.service will be actiwated which does n…
577debc 
…ot exists.

After Writing corosync confiugration Write(path, nil) will not be called. This causes that the corosync configuration will not be written inmediately bug only after the module is closed. This is especially a problem if the module is loaded from another module via the import function.
/etc/sysconfig/openais does not exists anymore. In code this agent will be called, which causes error logs. The corresponding SCR agent need to be removed.
liangxin1300
liangxin1300 approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick work!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varkoly @liangxin1300