Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12 Modify remaining issuses #13

Merged
merged 6 commits into from
May 24, 2020
Merged

#12 Modify remaining issuses #13

merged 6 commits into from
May 24, 2020

Conversation

ybkuroki
Copy link
Owner

Fixes #12 .

Changes proposed in this pull request:

  • Remove debug code in config.go.
  • Change table name for the following entities.
Entity Name Before After
Category categories category_master
Format formats format_master
  • Implement logger.
    • Logging kinds is the following
      • HTTP Request Logger
      • Controller Action Logger (Implement by echo middleware)
      • SQL Logger for gorm
  • Implement error handling.

@ybkuroki ybkuroki self-assigned this May 24, 2020
@ybkuroki ybkuroki added the enhancement New feature or request label May 24, 2020
ybkuroki
ybkuroki commented May 24, 2020
View reviewed changes
repository/repository.go Outdated
@@ -6,7 +6,9 @@ import (
"github.com/jinzhu/gorm"
_ "github.com/jinzhu/gorm/dialects/postgres" // indirect
_ "github.com/jinzhu/gorm/dialects/sqlite" // indirect
"github.com/labstack/echo"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from v3 to v4.

ybkuroki
ybkuroki commented May 24, 2020
View reviewed changes
go.mod Outdated
@@ -6,7 +6,9 @@ require (
github.com/go-playground/universal-translator v0.17.0 // indirect
github.com/jinzhu/configor v1.2.0
github.com/jinzhu/gorm v1.9.12
github.com/labstack/echo v3.3.10+incompatible
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove code

@ybkuroki ybkuroki merged commit 22af24e into master May 24, 2020
@ybkuroki ybkuroki deleted the #12 branch May 24, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ybkuroki ybkuroki

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining issuses
1 participant
@ybkuroki