Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "resolves #215" #217

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Revert "resolves #215" #217

merged 2 commits into from
Jul 5, 2021

Conversation

ycphs
Copy link
Owner

@ycphs ycphs commented Jul 5, 2021

Reverts #216

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #217 (00917a2) into master (00fc559) will increase coverage by 0.85%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   64.58%   65.44%   +0.85%     
==========================================
  Files          34       34              
  Lines        8876     8879       +3     
==========================================
+ Hits         5733     5811      +78     
+ Misses       3143     3068      -75     
Impacted Files Coverage Δ
R/openXL.R 0.00% <0.00%> (ø)
R/readWorkbook.R 87.68% <50.00%> (ø)
R/WorkbookClass.R 57.08% <100.00%> (+0.06%) ⬆️
R/workbook_write_data.R 91.50% <100.00%> (ø)
R/wrappers.R 51.06% <100.00%> (-0.04%) ⬇️
R/writeData.R 87.70% <0.00%> (+0.55%) ⬆️
R/worksheet_class.R 73.72% <0.00%> (+0.72%) ⬆️
src/helper_functions.cpp 91.56% <0.00%> (+17.46%) ⬆️
R/workbook_column_widths.R 63.72% <0.00%> (+43.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d179602...00917a2. Read the comment docs.

@ycphs ycphs merged commit 541a6ae into master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants