215 setops list #219
Merged
215 setops list #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had previously been failing due to test: "<definedName name=\"_xlnm._FilterDatabase\" localSheetId=\"0\" hidden=\"1\">'A & B < D > D'!$A$1:$A$10</definedName>"
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 64.58% 65.60% +1.01%
==========================================
Files 34 34
Lines 8876 8919 +43
==========================================
+ Hits 5733 5851 +118
+ Misses 3143 3068 -75
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects failures from the previous PR, due partially from not resetting options.
This also has a change for the internal
getDefinedNamesSheet()as that was causing some test failures. I'm not sure the quick-fix is made exactly as intended and it may warrant some additional testing.The
xml2package isn't imported in but may be a better/safer option if there are other uses. An example:Created on 2021-07-06 by the reprex package (v2.0.0)