Improve detectDates. closes #288

[JanMarvin]

Hackish attempt to fix #288

This PR checks if there is a numeric value, at a position, where we already expect a string of this type "yyyy-mm-dd". For whatever kind of reason, we end up here, with a numeric value in #288. Most likely due to the date being a POSIXct. Therefore most likely the fix is at the wrong position and should be somewhere else. For this minimal test file it should not matter, though with larger files we might waste a lot of time testing the conversion.

[codecov-commenter]

Codecov Report

Merging #291 (5b5340f) into master (d5c38ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   67.70%   67.71%   +0.01%     
==========================================
  Files          34       34              
  Lines        8897     8900       +3     
==========================================
+ Hits         6024     6027       +3     
  Misses       2873     2873              

Impacted Files	Coverage Δ
src/write_file.cpp	90.34% <100.00%> (+0.20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8b88c...5b5340f. Read the comment docs.

[cha-petersumm]

I still have issue, with a file that was simply written by openxlsx and then read back again (so Excel has never been near it).

write.xlsx(CVAD_list, "CVAD list.xlsx")
CVAD_list2 <- read.xlsx("CVAD list.xlsx")
CVAD_list3 <- read.xlsx("CVAD list.xlsx", detectDates = T)

Error message from the third line above is as follows:

Error reading date:
44696.5
row: 59
col: 6
Error: basic_string::substr: __pos (which is 8) > this->size() (which is 7)

There's nothing obviously odd about cell F59.

I'm happy to create an example that I can post if it would be useful.

packageVersion("openxlsx")
[1] ‘4.2.5.2’

[JanMarvin]

Hi @cha-petersumm , you can have a look at openxlsx2. The changes here went into the development branch, but never to CRAN.

[cha-petersumm]

Hi @cha-petersumm , you can have a look at openxlsx2. The changes here went into the development branch, but never to CRAN.

Thanks. That does appear to load from CRAN now, and it does fix the problem with dates. Great work!

As per https://cran.r-project.org/web/packages/openxlsx2/index.html.