Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve window size and position, also get and set #383

Closed
wants to merge 8 commits into from
Closed

Preserve window size and position, also get and set #383

wants to merge 8 commits into from

Conversation

michael-dewar
Copy link
Contributor

This PR will preserve the size and position of the window when you open the xlsx in Excel. There are also functions to set and get directly.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #383 (3f91f18) into master (e7b699e) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   67.76%   67.90%   +0.14%     
==========================================
  Files          34       35       +1     
  Lines        8931     8970      +39     
==========================================
+ Hits         6052     6091      +39     
  Misses       2879     2879              
Impacted Files Coverage Δ
R/writeData.R 88.33% <ø> (ø)
R/WorkbookClass.R 60.53% <100.00%> (+0.09%) ⬆️
R/loadWorkbook.R 83.78% <100.00%> (+0.31%) ⬆️
R/setWindowSize.R 100.00% <100.00%> (ø)
R/workbook_write_data.R 92.99% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JanMarvin
Copy link
Collaborator

Hi @michael-dewar , looking good. Just minor lintr issues and I'd like to see a test for this as well.

@michael-dewar
Copy link
Contributor Author

I fixed the linter issues for the code I changed. I mostly avoided changing the other sections because I wasn't actually sure if the & vs && change made a difference compared to what was intended.

I also added tests.

@JanMarvin
Copy link
Collaborator

Thanks, the other changes should be in the development branch

@JanMarvin JanMarvin changed the base branch from master to development September 26, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants