-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve window size and position, also get and set #383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 67.76% 67.90% +0.14%
==========================================
Files 34 35 +1
Lines 8931 8970 +39
==========================================
+ Hits 6052 6091 +39
Misses 2879 2879
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @michael-dewar , looking good. Just minor lintr issues and I'd like to see a test for this as well. |
I fixed the linter issues for the code I changed. I mostly avoided changing the other sections because I wasn't actually sure if the & vs && change made a difference compared to what was intended. I also added tests. |
Thanks, the other changes should be in the |
This PR will preserve the size and position of the window when you open the xlsx in Excel. There are also functions to set and get directly.