Preserve window size and position, also get and set

.github/workflows/R-CMD-check.yaml

@@ -1,15 +1,15 @@
 # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
+# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
 on:
   push:
     branches: [main, master]
   pull_request:
     branches: [main, master]
-  schedule:
-    # * is a special character in YAML so you have to quote this string
-    - cron:  '0 12 * * *'
 
 name: R-CMD-check
 
+permissions: read-all
+
 jobs:
   R-CMD-check:
     runs-on: ${{ matrix.config.os }}
@@ -20,25 +20,18 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - {os: windows-latest, r: 'oldrel-1'}
+          - {os: macos-latest,   r: 'release'}
           - {os: windows-latest, r: 'release'}
-          - {os: windows-latest, r: 'devel', http-user-agent: 'release'}
-          - {os: macOS-latest, r: 'oldrel-1'}
-          - {os: macOS-latest, r: 'release'}
-          - {os: macOS-latest, r: 'devel', http-user-agent: 'release'}
-          - {os: ubuntu-latest, r: 'oldrel-1'}
-          - {os: ubuntu-latest, r: 'release'}
-          - {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
+          - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}
+          - {os: ubuntu-latest,   r: 'release'}
+          - {os: ubuntu-latest,   r: 'oldrel-1'}
 
     env:
-      R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
-      RSPM: ${{ matrix.config.rspm }}
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
-
-    if: "!contains(github.event.head_commit.message, 'revdepcheck run - No changes to commit')"
+      R_KEEP_PKG_SOURCE: yes
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - uses: r-lib/actions/setup-pandoc@v2
 
@@ -55,4 +48,5 @@ jobs:
 
       - uses: r-lib/actions/check-r-package@v2
         with:
-          upload-snapshots: true
+          upload-snapshots: true
+          build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'

.github/workflows/lint.yaml

@@ -2,19 +2,21 @@
 # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
 on:
   push:
-    branches: [main, master, development]
+    branches: [main, master]
   pull_request:
-    branches: [main, master, development]
+    branches: [main, master]
 
 name: lint
 
+permissions: read-all
+
 jobs:
   lint:
     runs-on: ubuntu-latest
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - uses: r-lib/actions/setup-r@v2
         with:
@@ -28,3 +30,5 @@ jobs:
       - name: Lint
         run: lintr::lint_package()
         shell: Rscript {0}
+        env:
+          LINTR_ERROR_ON_LINT: true

.github/workflows/recheck.yml

@@ -0,0 +1,18 @@
+on:
+  workflow_dispatch:
+    inputs:
+      which:
+        type: choice
+        description: Which dependents to check
+        options:
+        - strong
+        - most
+
+name: Reverse dependency check
+
+jobs:
+  revdep_check:
+    name: Reverse check ${{ inputs.which }} dependents
+    uses: r-devel/recheck/.github/workflows/recheck.yml@v1
+    with:
+      which: ${{ inputs.which }}

.gitignore

@@ -1,6 +1,7 @@
 .Rproj.user
 .Rhistory
 .RData
+.DS_Store
 src/*.o
 src/*.so
 src/*.dll
@@ -19,3 +20,4 @@ docs/
 openxlsx.Rcheck/
 openxlsx*.tar.gz
 openxlsx*.tgz
+vignettes/*

.lintr

@@ -10,8 +10,14 @@ linters: linters_with_defaults(
   function_left_parentheses_linter = NULL, #
   spaces_inside_linter = NULL,             #
   spaces_left_parentheses_linter = NULL,   #
-  no_tab_linter = NULL,                    #
-  single_quotes_linter = NULL,             #
   object_length_linter = NULL,             #
-  assignment_linter = NULL                 # just one case
+  assignment_linter = NULL,                # just one case
+  vector_logic_linter = NULL,              # many
+  indentation_linter = NULL,               # many
+  quotes_linter = NULL,
+  T_and_F_symbol_linter = NULL,
+  seq_linter = NULL,
+  trailing_blank_lines_linter = NULL,
+  paren_body_linter = NULL,
+  semicolon_linter = NULL
   )

DESCRIPTION

@@ -1,12 +1,12 @@
 Type: Package
 Package: openxlsx
 Title: Read, Write and Edit xlsx Files
-Version: 4.2.5.9001
-Date: 2021-12-13
+Version: 4.2.6.1
+Date: 2024-07-23
 Authors@R: 
     c(person(given = "Philipp",
              family = "Schauberger",
-             role = c("aut", "cre"),
+             role = "aut",
              email = "[email protected]"),
       person(given = "Alexander",
              family = "Walker",
@@ -20,7 +20,7 @@ Authors@R:
              role = "ctb"),
       person(given = "Jan Marvin",
              family = "Garbuszus",
-             role = "ctb",
+             role = c("ctb", "cre"),
              email = "[email protected]"),
       person(given = "Jordan Mark",
              family = "Barbone",
@@ -51,6 +51,8 @@ Imports:
     utils,
     zip
 Suggests:
+    curl,
+    formula.tools,
     knitr,
     rmarkdown,
     testthat
@@ -60,7 +62,7 @@ VignetteBuilder:
     knitr
 Encoding: UTF-8
 Language: en-US
-RoxygenNote: 7.2.0
+RoxygenNote: 7.3.2
 Collate: 
     'CommentClass.R'
     'HyperlinkClass.R'
@@ -83,6 +85,7 @@ Collate:
     'openxlsx.R'
     'openxlsxCoerce.R'
     'readWorkbook.R'
+    'setWindowSize.R'
     'sheet_data_class.R'
     'utils.R'
     'workbook_column_widths.R'
@@ -95,3 +98,4 @@ Collate:
     'writexlsx.R'
     'zzz.R'
 Roxygen: list(markdown = TRUE)
+LazyData: true

LICENSE

@@ -1,2 +1,2 @@
-YEAR: 2014-2022
+YEAR: 2014-2024
 COPYRIGHT HOLDER: openxlsx authors

NAMESPACE

@@ -42,6 +42,7 @@ export(getNamedRegions)
 export(getSheetNames)
 export(getStyles)
 export(getTables)
+export(getWindowSize)
 export(groupColumns)
 export(groupRows)
 export(insertImage)
@@ -77,6 +78,7 @@ export(setHeader)
 export(setHeaderFooter)
 export(setLastModifiedBy)
 export(setRowHeights)
+export(setWindowSize)
 export(sheetVisibility)
 export(sheetVisible)
 export(sheets)

NEWS.md

@@ -1,5 +1,7 @@
-# openxlsx (development version)
+# openxlsx 4.2.6
 
+* Fix external links ([#410](https://github.com/ycphs/openxlsx/pull/410))
+* Do not add unneccessary sheetPr node ([#409](https://github.com/ycphs/openxlsx/pull/409))
 * Add support for `namedRegion`s having dots and other special characters ([#338](https://github.com/ycphs/openxlsx/issues/338)).
 * Add type blanks and not blanks to conditional formatting ([#311](https://github.com/ycphs/openxlsx/pull/311))
 

R/WorkbookClass.R

@@ -3238,6 +3238,12 @@ Workbook$methods(
       workbook$sheets <<- workbook$sheets[sheetOrder]
     }
 
+    ## preserve window size and position on save:
+    bookViews <-workbook$bookViews
+    xWindow <- getAttrs(bookViews, "xWindow")$xWindow
+    yWindow <- getAttrs(bookViews, "yWindow")$yWindow
+    windowWidth <- getAttrs(bookViews, "windowWidth")$windowWidth
+    windowHeight <- getAttrs(bookViews, "windowHeight")$windowHeight
 
 
     ## re-assign tabSelected
@@ -3247,7 +3253,8 @@ Workbook$methods(
     visible_sheets <- which(state %in% "visible")
     workbook$bookViews <<-
       sprintf(
-        '<bookViews><workbookView xWindow="0" yWindow="0" windowWidth="13125" windowHeight="6105" firstSheet="%s" activeTab="%s"/></bookViews>',
+        '<bookViews><workbookView xWindow="%s" yWindow="%s" windowWidth="%s" windowHeight="%s" firstSheet="%s" activeTab="%s"/></bookViews>',
+        xWindow, yWindow, windowWidth, windowHeight,
         visible_sheet_index - 1L,
         ActiveSheet - 1L
       )