Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement allowlist to skip authentication #9

Merged
merged 5 commits into from
Jan 12, 2022
Merged

feat: implement allowlist to skip authentication #9

merged 5 commits into from
Jan 12, 2022

Conversation

wsalles
Copy link
Contributor

@wsalles wsalles commented Jan 6, 2022 •
edited by jira bot
Loading

closes PLT-125

@wsalles wsalles requested a review from portellaa January 6, 2022 18:48
@wsalles wsalles self-assigned this Jan 6, 2022
portellaa
portellaa reviewed Jan 6, 2022
View reviewed changes
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/clients/oidc.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Jan 12, 2022
View reviewed changes
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the name that we discussed

@wsalles wsalles requested a review from portellaa January 12, 2022 15:11
@wsalles wsalles requested a review from portellaa January 12, 2022 15:25
@wsalles wsalles merged commit 8aba2d0 into master Jan 12, 2022
@wsalles wsalles deleted the feat/PLT-125 branch January 12, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatoaguimaraes renatoaguimaraes renatoaguimaraes approved these changes

@portellaa portellaa Awaiting requested review from portellaa

Assignees

@wsalles wsalles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsalles @portellaa @renatoaguimaraes