Decimal #193
Merged
Decimal #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Apr 16, 2024
| precision: decimal.precision, | ||
| scale: decimal.scale, | ||
| precision: decimal.precision as u8, | ||
| scale: decimal.scale as i16, |
There was a problem hiding this comment.
What about use TryInto/TryFrom, for detect if outranges values as error?
| @@ -160,6 +174,22 @@ impl TryFrom<crate::Value> for RawTypedValue { | |||
| } | |||
| } | |||
|
|
|||
| #[repr(C)] | |||
| pub(crate) union DecimalUnion { | |||
There was a problem hiding this comment.
It is first usage of unsafe in the SDK.
Is other way for split i128 to u64 parts exists?
There was a problem hiding this comment.
I done it without unsafe
|
Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
There is no decimal support in the library
Issue Number: N/A
What is the new behavior?
Implemented decimal type
Other information