feat: add slo tests #217
Merged
feat: add slo tests #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
10 times, most recently
from
0598158 to
afe0f65
Compare
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
5 times, most recently
from
8615eed to
240fd50
Compare
rekby
reviewed
Jan 22, 2025
| payload_double Double?, | ||
| payload_timestamp Timestamp?, | ||
| payload_hash Uint64?, | ||
| PRIMARY KEY (hash, id) |
There was a problem hiding this comment.
Better do not set primary key fields as optional - NULL values in primary key are difficult to right select/filter/iterate.
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
7 times, most recently
from
db9b9b5 to
8253219
Compare
polRk
reviewed
Jan 24, 2025
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
5 times, most recently
from
3741b13 to
989bf7c
Compare
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
2 times, most recently
from
4a7df34 to
561afb6
Compare
fatalem0
force-pushed
the
fatalem0/add-slo-tests
branch
from
561afb6 to
743b553
Compare
rekby
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information