Skip to content

Commit

Permalink
Fixed integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
GrigoriyPA committed Oct 11, 2024
1 parent bc0ce3f commit 943f055
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions ydb/core/fq/libs/row_dispatcher/json_filter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <ydb/library/yql/minikql/mkql_alloc.h>
#include <ydb/library/yql/minikql/computation/mkql_computation_node_holders.h>
#include <ydb/library/yql/minikql/mkql_terminator.h>
#include <ydb/library/yql/minikql/mkql_string_util.h>

#include <ydb/core/fq/libs/row_dispatcher/json_filter.h>
#include <ydb/core/fq/libs/actors/logging/log.h>
Expand Down Expand Up @@ -111,10 +112,7 @@ class TFilterInputConsumer : public NYql::NPureCalc::IConsumer<std::pair<ui64, c

size_t fieldId = 0;
for (const auto& column : values.second) {
items[FieldsPositions[fieldId++]] = NYql::NUdf::TUnboxedValuePod(column[rowId].empty()
? NYql::NUdf::TStringValue("\0")
: NYql::NUdf::TStringValue(column[rowId])
);
items[FieldsPositions[fieldId++]] = NKikimr::NMiniKQL::MakeString(column[rowId]);
}

Worker->Push(std::move(result));
Expand Down
2 changes: 1 addition & 1 deletion ydb/tests/fq/yds/test_row_dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ def test_filter_missing_fields(self, kikimr, client):
INSERT INTO {YDS_CONNECTION}.`{self.output_topic}`
SELECT Cast(time as String) FROM {YDS_CONNECTION}.`{self.input_topic}`
WITH (format=json_each_row, SCHEMA (time UInt64 NOT NULL, data String, event String NOT NULL))
WHERE data IS NULL or data = "";'''
WHERE data = "";'''

query_id = start_yds_query(kikimr, client, sql)
wait_actor_count(kikimr, "FQ_ROW_DISPATCHER_SESSION", 1)
Expand Down

0 comments on commit 943f055

Please sign in to comment.