Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix splitter condition to avoid split micro-chunks #10375

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 08:30:43 UTC Pre-commit check linux-x86_64-release-asan for 0bf2299 has started.
2024-10-14 08:30:47 UTC Check cancelled

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 08:31:26 UTC Pre-commit check linux-x86_64-release-asan for d1bc521 has started.
2024-10-14 08:31:58 UTC Artifacts will be uploaded here
2024-10-14 08:35:42 UTC ya make is running...
🟡 2024-10-14 10:06:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11633 11398 0 65 62 108

🟢 2024-10-14 10:07:29 UTC Build successful.
🟢 2024-10-14 10:08:03 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 56e8de9 merge: d1bc521 diff diff %
ydbd size 6 095 952 920 Bytes 6 095 952 824 Bytes -96 Bytes -0.000%
ydbd stripped size 1 520 298 160 Bytes 1 520 298 096 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 14, 2024

2024-10-14 08:33:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for d1bc521 has started.
2024-10-14 08:33:33 UTC Artifacts will be uploaded here
2024-10-14 08:36:37 UTC ya make is running...
🟡 2024-10-14 09:41:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41363 35785 0 2 5471 105

2024-10-14 09:45:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 09:57:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 5 0 0 0 100

🟢 2024-10-14 09:57:17 UTC Build successful.
🟢 2024-10-14 09:57:37 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 56e8de9 merge: d1bc521 diff diff %
ydbd size 3 009 132 376 Bytes 3 009 132 376 Bytes 0 Bytes 0.000%
ydbd stripped size 477 352 568 Bytes 477 352 568 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny linked an issue Oct 14, 2024 that may be closed by this pull request
@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review October 14, 2024 16:21
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner October 14, 2024 16:21
@ivanmorozov333 ivanmorozov333 merged commit e2fabd1 into ydb-platform:main Oct 14, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_condition_for_split branch October 14, 2024 16:21
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS Fails on SplitBySizes
2 participants