Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ RD fixed use after free #10978

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Oct 28, 2024

Changelog entry

Fixed use after free

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 28, 2024 09:46
@GrigoriyPA GrigoriyPA requested a review from kardymonds October 28, 2024 09:47
Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 09:49:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for a1ea2f7 has started.
2024-10-28 09:49:45 UTC Artifacts will be uploaded here
2024-10-28 09:52:46 UTC ya make is running...
🟡 2024-10-28 10:46:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39815 34144 0 34 5539 98

2024-10-28 10:49:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-28 11:01:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 12 0 23 0 95

2024-10-28 11:01:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-28 11:12:44 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 0 0 23 0 95

🟢 2024-10-28 11:12:50 UTC Build successful.
🟢 2024-10-28 11:13:12 UTC ydbd size 2.8 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0c2b198 merge: a1ea2f7 diff diff %
ydbd size 3 033 259 944 Bytes 3 033 262 400 Bytes +2.4 KiB +0.000%
ydbd stripped size 480 589 400 Bytes 480 589 656 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 09:50:04 UTC Pre-commit check linux-x86_64-release-asan for a1ea2f7 has started.
2024-10-28 09:50:14 UTC Artifacts will be uploaded here
2024-10-28 09:53:13 UTC ya make is running...
🟡 2024-10-28 11:04:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9967 9779 0 53 35 100

🟢 2024-10-28 11:05:04 UTC Build successful.
🟢 2024-10-28 11:05:39 UTC ydbd size 5.7 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0c2b198 merge: a1ea2f7 diff diff %
ydbd size 6 138 337 856 Bytes 6 138 340 704 Bytes +2.8 KiB +0.000%
ydbd stripped size 1 531 814 832 Bytes 1 531 815 216 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 16:11:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 204db11 has started.
2024-10-28 16:11:54 UTC Artifacts will be uploaded here
2024-10-28 16:14:53 UTC ya make is running...
🔴 2024-10-28 16:19:43 UTC Build failed, see the logs. Also see fail summary
🟢 2024-10-28 16:19:54 UTC ydbd size 2.8 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d4eaec4 merge: 204db11 diff diff %
ydbd size 3 033 914 584 Bytes 3 033 917 344 Bytes +2.7 KiB +0.000%
ydbd stripped size 480 680 664 Bytes 480 680 856 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 16:12:19 UTC Pre-commit check linux-x86_64-release-asan for 204db11 has started.
2024-10-28 16:12:57 UTC Artifacts will be uploaded here
2024-10-28 16:16:33 UTC ya make is running...
🟡 2024-10-28 17:18:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9315 9163 0 32 24 96

🟢 2024-10-28 17:19:33 UTC Build successful.
🟢 2024-10-28 17:20:04 UTC ydbd size 5.7 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d4eaec4 merge: 204db11 diff diff %
ydbd size 6 139 704 984 Bytes 6 139 709 192 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 532 094 704 Bytes 1 532 095 280 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Oct 29, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 07:34:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for f81f0a9 has started.
2024-10-29 07:34:29 UTC Artifacts will be uploaded here
2024-10-29 07:37:27 UTC ya make is running...
🟡 2024-10-29 08:31:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39820 34178 0 2 5539 101

2024-10-29 08:34:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-29 08:46:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 8 0 0 0 94

🟢 2024-10-29 08:46:30 UTC Build successful.
🟢 2024-10-29 08:46:50 UTC ydbd size 2.8 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 903c6b6 merge: f81f0a9 diff diff %
ydbd size 3 033 922 776 Bytes 3 033 925 592 Bytes +2.8 KiB +0.000%
ydbd stripped size 480 682 264 Bytes 480 682 520 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 07:34:21 UTC Pre-commit check linux-x86_64-release-asan for f81f0a9 has started.
2024-10-29 07:34:31 UTC Artifacts will be uploaded here
2024-10-29 07:37:30 UTC ya make is running...
🟡 2024-10-29 08:42:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9311 8991 0 39 247 34

🟢 2024-10-29 08:43:26 UTC Build successful.
🟢 2024-10-29 08:43:58 UTC ydbd size 5.7 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 903c6b6 merge: f81f0a9 diff diff %
ydbd size 6 139 714 808 Bytes 6 139 719 008 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 532 099 056 Bytes 1 532 099 632 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 11838a0 into ydb-platform:main Oct 29, 2024
13 of 14 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-RD-fixed-use-after-free branch October 29, 2024 09:23
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Oct 29, 2024
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants