Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error on start internal scanner #11289

Merged
merged 10 commits into from
Nov 12, 2024
Merged

fix error on start internal scanner #11289

merged 10 commits into from
Nov 12, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

@github-actions github-actions bot added the bugfix label Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

⚪ 2024-11-05 16:17:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2083e8 has started.
⚪ 2024-11-05 16:17:36 UTC Artifacts will be uploaded here
⚪ 2024-11-05 16:20:36 UTC ya make is running...
🟡 2024-11-05 17:05:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15059 13552 0 3 1404 100

⚪ 2024-11-05 17:06:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-05 17:17:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
103 (only retried tests) 8 0 0 1 94

🟢 2024-11-05 17:17:53 UTC Build successful.
🟢 2024-11-05 17:18:12 UTC ydbd size 2.8 GiB changed* by +99.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3a6411f merge: a2083e8 diff diff %
ydbd size 3 039 618 920 Bytes 3 039 720 480 Bytes +99.2 KiB +0.003%
ydbd stripped size 481 640 696 Bytes 481 660 216 Bytes +19.1 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

⚪ 2024-11-05 16:17:45 UTC Pre-commit check linux-x86_64-release-asan for a2083e8 has started.
⚪ 2024-11-05 16:17:54 UTC Artifacts will be uploaded here
⚪ 2024-11-05 16:20:52 UTC ya make is running...
🟡 2024-11-05 17:24:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9170 9101 0 30 8 31

🟢 2024-11-05 17:25:24 UTC Build successful.
🟡 2024-11-05 17:25:56 UTC ydbd size 5.7 GiB changed* by +208.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3a6411f merge: a2083e8 diff diff %
ydbd size 6 150 742 824 Bytes 6 150 956 168 Bytes +208.3 KiB +0.003%
ydbd stripped size 1 535 210 128 Bytes 1 535 282 416 Bytes +70.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov mentioned this pull request Nov 7, 2024
Closed
@ivanmorozov333 ivanmorozov333 force-pushed the fix_error_on_start_scanner_internal branch from 669f6f5 to faeab6d Compare November 12, 2024 10:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:34:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 38a18ac has started.
⚪ 2024-11-12 10:34:17 UTC Artifacts will be uploaded here
⚪ 2024-11-12 10:37:16 UTC ya make is running...
⚫ 2024-11-12 10:40:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:34:14 UTC Pre-commit check linux-x86_64-release-asan for 38a18ac has started.
⚪ 2024-11-12 10:34:56 UTC Artifacts will be uploaded here
⚪ 2024-11-12 10:38:27 UTC ya make is running...
⚫ 2024-11-12 10:40:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:41:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 806313d has started.
⚪ 2024-11-12 10:41:48 UTC Artifacts will be uploaded here
⚫ 2024-11-12 10:42:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:41:42 UTC Pre-commit check linux-x86_64-release-asan for 806313d has started.
⚪ 2024-11-12 10:41:46 UTC Artifacts will be uploaded here
⚫ 2024-11-12 10:42:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:45:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for f29ebe8 has started.
⚪ 2024-11-12 10:45:45 UTC Artifacts will be uploaded here
⚪ 2024-11-12 10:48:43 UTC ya make is running...
⚫ 2024-11-12 11:23:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 10:45:38 UTC Pre-commit check linux-x86_64-release-asan for f29ebe8 has started.
⚪ 2024-11-12 10:45:49 UTC Artifacts will be uploaded here
⚪ 2024-11-12 10:48:53 UTC ya make is running...
⚫ 2024-11-12 11:23:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 11:27:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2861f8b has started.
⚪ 2024-11-12 11:27:29 UTC Artifacts will be uploaded here
⚪ 2024-11-12 11:30:29 UTC ya make is running...
🟡 2024-11-12 12:17:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15128 13592 0 16 1405 115

⚪ 2024-11-12 12:18:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 12:28:31 UTC ydbd size 2.8 GiB changed* by +504 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: a2e65ee merge: 2861f8b diff diff %
ydbd size 3 049 941 624 Bytes 3 049 942 128 Bytes +504 Bytes +0.000%
ydbd stripped size 482 445 048 Bytes 482 445 240 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-11-12 12:28:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 11:27:46 UTC Pre-commit check linux-x86_64-release-asan for 2861f8b has started.
⚪ 2024-11-12 11:27:57 UTC Artifacts will be uploaded here
⚪ 2024-11-12 11:30:57 UTC ya make is running...
⚫ 2024-11-12 12:28:21 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 12:30:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4db8bb6 has started.
⚪ 2024-11-12 12:31:09 UTC Artifacts will be uploaded here
⚪ 2024-11-12 12:34:09 UTC ya make is running...
🟡 2024-11-12 13:21:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15131 13600 0 12 1405 114

⚪ 2024-11-12 13:22:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 13:25:23 UTC ydbd size 2.8 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 91cc642 merge: 4db8bb6 diff diff %
ydbd size 3 049 967 472 Bytes 3 049 979 312 Bytes +11.6 KiB +0.000%
ydbd stripped size 482 451 704 Bytes 482 454 776 Bytes +3.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-11-12 13:25:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 12:32:43 UTC Pre-commit check linux-x86_64-release-asan for 4db8bb6 has started.
⚪ 2024-11-12 12:32:55 UTC Artifacts will be uploaded here
⚪ 2024-11-12 12:35:55 UTC ya make is running...
⚫ 2024-11-12 13:25:14 UTC Check cancelled

nikvas0
nikvas0 previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 13:27:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b503d5 has started.
⚪ 2024-11-12 13:27:36 UTC Artifacts will be uploaded here
⚪ 2024-11-12 13:30:34 UTC ya make is running...
🟡 2024-11-12 14:19:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15136 13606 0 13 1405 112

⚪ 2024-11-12 14:20:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 14:32:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 12 0 0 0 109

🟢 2024-11-12 14:32:18 UTC Build successful.
🟢 2024-11-12 14:32:40 UTC ydbd size 2.8 GiB changed* by +496 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1765fb merge: 1b503d5 diff diff %
ydbd size 3 050 013 944 Bytes 3 050 014 440 Bytes +496 Bytes +0.000%
ydbd stripped size 482 458 808 Bytes 482 459 000 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 13:27:43 UTC Pre-commit check linux-x86_64-release-asan for 1b503d5 has started.
⚪ 2024-11-12 13:27:54 UTC Artifacts will be uploaded here
⚪ 2024-11-12 13:31:09 UTC ya make is running...
🟡 2024-11-12 14:41:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8951 8822 0 62 19 48

🟢 2024-11-12 14:42:42 UTC Build successful.
🟢 2024-11-12 14:43:17 UTC ydbd size 5.7 GiB changed* by +328 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f1765fb merge: 1b503d5 diff diff %
ydbd size 6 172 404 848 Bytes 6 172 405 176 Bytes +328 Bytes +0.000%
ydbd stripped size 1 538 432 368 Bytes 1 538 432 176 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 14:49:38 UTC Pre-commit check linux-x86_64-release-asan for d4b06f3 has started.
⚪ 2024-11-12 14:49:49 UTC Artifacts will be uploaded here
⚪ 2024-11-12 14:52:48 UTC ya make is running...
🟡 2024-11-12 16:02:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8947 8840 0 47 12 48

🟢 2024-11-12 16:03:20 UTC Build successful.
🟢 2024-11-12 16:03:50 UTC ydbd size 5.7 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8fb382c merge: d4b06f3 diff diff %
ydbd size 6 172 427 272 Bytes 6 172 427 144 Bytes -128 Bytes -0.000%
ydbd stripped size 1 538 434 928 Bytes 1 538 434 864 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 14:49:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4b06f3 has started.
⚪ 2024-11-12 14:49:49 UTC Artifacts will be uploaded here
⚪ 2024-11-12 14:52:54 UTC ya make is running...
🟡 2024-11-12 15:52:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15139 13606 0 15 1405 113

⚪ 2024-11-12 15:53:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 16:04:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 13 0 0 0 108

🟢 2024-11-12 16:04:52 UTC Build successful.
🟢 2024-11-12 16:05:11 UTC ydbd size 2.8 GiB changed* by +296 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8fb382c merge: d4b06f3 diff diff %
ydbd size 3 050 027 088 Bytes 3 050 027 384 Bytes +296 Bytes +0.000%
ydbd stripped size 482 461 432 Bytes 482 461 624 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 16:25:15 UTC Pre-commit check linux-x86_64-release-asan for dedb737 has started.
⚪ 2024-11-12 16:25:28 UTC Artifacts will be uploaded here
⚪ 2024-11-12 16:28:37 UTC ya make is running...
🟡 2024-11-12 17:36:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8944 8856 0 32 11 45

🟢 2024-11-12 17:37:21 UTC Build successful.
🟢 2024-11-12 17:37:55 UTC ydbd size 5.7 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8fb382c merge: dedb737 diff diff %
ydbd size 6 172 427 272 Bytes 6 172 427 304 Bytes +32 Bytes +0.000%
ydbd stripped size 1 538 434 928 Bytes 1 538 434 928 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

⚪ 2024-11-12 16:25:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for dedb737 has started.
⚪ 2024-11-12 16:25:47 UTC Artifacts will be uploaded here
⚪ 2024-11-12 16:28:46 UTC ya make is running...
🟡 2024-11-12 17:16:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15139 13607 0 12 1405 115

⚪ 2024-11-12 17:18:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 17:30:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 11 0 0 0 109

🟢 2024-11-12 17:30:08 UTC Build successful.
🟢 2024-11-12 17:30:28 UTC ydbd size 2.8 GiB changed* by +296 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c9d166e merge: dedb737 diff diff %
ydbd size 3 050 027 088 Bytes 3 050 027 384 Bytes +296 Bytes +0.000%
ydbd stripped size 482 461 432 Bytes 482 461 624 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 12, 2024 17:26
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 12, 2024 17:26
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) November 12, 2024 17:35
@ivanmorozov333 ivanmorozov333 merged commit d4c693f into ydb-platform:main Nov 12, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_error_on_start_scanner_internal branch November 12, 2024 17:41
@vlad-gogov vlad-gogov linked an issue Nov 13, 2024 that may be closed by this pull request
All databases nodes crashes while executing even the most simple INSERT INTO SELECT FROM query #11186
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
@vlad-gogov vlad-gogov mentioned this pull request Nov 14, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 14, 2024
Merged
vlad-gogov added a commit to vlad-gogov/ydb that referenced this pull request Nov 15, 2024
@ivanmorozov333 @vlad-gogov
fix error on start internal scanner (ydb-platform#11289)
167a6e1 
Co-authored-by: vlad-gogov <[email protected]>
vlad-gogov added a commit to vlad-gogov/ydb that referenced this pull request Nov 15, 2024
@vlad-gogov
fix error on start internal scanner (ydb-platform#11289)
51f444d
@vlad-gogov vlad-gogov mentioned this pull request Nov 15, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
@ivanmorozov333 @vlad-gogov @zverevgeny
fix error on start internal scanner (ydb-platform#11289)
5f00d53 
Co-authored-by: vlad-gogov <[email protected]>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @vlad-gogov @zverevgeny
fix error on start internal scanner (ydb-platform#11289)
c2c54d8 
Co-authored-by: vlad-gogov <[email protected]>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @vlad-gogov @zverevgeny
fix error on start internal scanner (ydb-platform#11289)
bb28e02 
Co-authored-by: vlad-gogov <[email protected]>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
@ivanmorozov333 @vlad-gogov @zverevgeny
fix error on start internal scanner (ydb-platform#11289)
a3d45fb 
Co-authored-by: vlad-gogov <[email protected]>
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-gogov vlad-gogov vlad-gogov approved these changes

@nikvas0 nikvas0 nikvas0 left review comments

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All databases nodes crashes while executing even the most simple INSERT INTO SELECT FROM query
3 participants
@ivanmorozov333 @nikvas0 @vlad-gogov