Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI error "Failed to resolve database" #11841

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix UI error "Failed to resolve database" #11841

merged 2 commits into from
Nov 29, 2024

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Nov 21, 2024 •
edited
Loading

Changelog entry

In 24-3, support for redirecting requests to dynodes was added. The fix adjusts the scenario where a redirect is not possible: instead of throwing a "Failed to resolve database" error, the request is processed locally on the node that received it.

Changelog category

  • Improvement

@StekPerepolnen StekPerepolnen requested a review from a team as a code owner November 21, 2024 11:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 11:55:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8f9832a has started.
⚪ 2024-11-21 11:55:36 UTC Artifacts will be uploaded here
⚫ 2024-11-21 11:58:26 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 11:56:36 UTC Pre-commit check linux-x86_64-release-asan for 8f9832a has started.
⚪ 2024-11-21 11:56:47 UTC Artifacts will be uploaded here
⚫ 2024-11-21 11:58:26 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 12:01:02 UTC Pre-commit check linux-x86_64-release-asan for 9030cf6 has started.
⚪ 2024-11-21 12:01:14 UTC Artifacts will be uploaded here
⚪ 2024-11-21 12:04:19 UTC ya make is running...
⚫ 2024-11-21 12:06:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 12:01:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9030cf6 has started.
⚪ 2024-11-21 12:01:21 UTC Artifacts will be uploaded here
⚪ 2024-11-21 12:04:26 UTC ya make is running...
⚫ 2024-11-21 12:06:13 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 12:07:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for eb1cbb6 has started.
⚪ 2024-11-21 12:08:03 UTC Artifacts will be uploaded here
⚪ 2024-11-21 12:10:55 UTC ya make is running...
🟢 2024-11-21 12:59:06 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15086 13570 0 0 1405 111

🟢 2024-11-21 13:00:30 UTC Build successful.
🟢 2024-11-21 13:00:46 UTC ydbd size 2.5 GiB changed* by -2.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f5d673a merge: eb1cbb6 diff diff %
ydbd size 2 689 674 384 Bytes 2 689 671 856 Bytes -2.5 KiB -0.000%
ydbd stripped size 481 837 872 Bytes 481 837 232 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 12:10:18 UTC Pre-commit check linux-x86_64-release-asan for eb1cbb6 has started.
⚪ 2024-11-21 12:10:29 UTC Artifacts will be uploaded here
⚪ 2024-11-21 12:13:23 UTC ya make is running...
🟡 2024-11-21 13:14:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8852 8787 0 14 6 45

🟢 2024-11-21 13:15:45 UTC Build successful.
🟢 2024-11-21 13:16:12 UTC ydbd size 4.9 GiB changed* by -928 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 923d372 merge: eb1cbb6 diff diff %
ydbd size 5 280 965 384 Bytes 5 280 964 456 Bytes -928 Bytes -0.000%
ydbd stripped size 1 358 519 792 Bytes 1 358 519 536 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen changed the title viewer redirect 2 UI Failed to resolve database Nov 22, 2024
@StekPerepolnen StekPerepolnen changed the title UI Failed to resolve database Viewer returns Failed to resolve database Nov 22, 2024
@StekPerepolnen StekPerepolnen force-pushed the viewer-redirect-2 branch 3 times, most recently from dae798d to 67f2f03 Compare November 25, 2024 08:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 08:52:37 UTC Pre-commit check linux-x86_64-release-asan for b12a375 has started.
⚪ 2024-11-25 08:52:48 UTC Artifacts will be uploaded here
⚪ 2024-11-25 08:55:39 UTC ya make is running...
🟡 2024-11-25 10:12:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8856 8784 0 17 7 48

🟢 2024-11-25 10:13:32 UTC Build successful.
🟢 2024-11-25 10:13:59 UTC ydbd size 4.9 GiB changed* by -784 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b07b2ad merge: b12a375 diff diff %
ydbd size 5 284 305 560 Bytes 5 284 304 776 Bytes -784 Bytes -0.000%
ydbd stripped size 1 359 965 488 Bytes 1 359 965 360 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 08:54:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for b12a375 has started.
⚪ 2024-11-25 08:55:06 UTC Artifacts will be uploaded here
⚪ 2024-11-25 08:58:00 UTC ya make is running...
🟢 2024-11-25 09:45:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15080 13571 0 0 1396 113

🟢 2024-11-25 09:46:53 UTC Build successful.
🟢 2024-11-25 09:47:10 UTC ydbd size 2.5 GiB changed* by -872 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d07a485 merge: b12a375 diff diff %
ydbd size 2 690 049 400 Bytes 2 690 048 528 Bytes -872 Bytes -0.000%
ydbd stripped size 482 184 656 Bytes 482 184 528 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:01:47 UTC Pre-commit check linux-x86_64-release-asan for a8336e4 has started.
⚪ 2024-11-25 15:02:02 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:05:05 UTC ya make is running...
🟡 2024-11-25 16:16:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8855 8787 0 12 8 48

🟢 2024-11-25 16:16:55 UTC Build successful.
🟢 2024-11-25 16:17:25 UTC ydbd size 4.9 GiB changed* by -776 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1dd2b99 merge: a8336e4 diff diff %
ydbd size 5 284 460 056 Bytes 5 284 459 280 Bytes -776 Bytes -0.000%
ydbd stripped size 1 359 983 856 Bytes 1 359 983 600 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:05:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for a8336e4 has started.
⚪ 2024-11-25 15:05:31 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:08:25 UTC ya make is running...
🟡 2024-11-25 15:58:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15081 13568 0 2 1396 115

⚪ 2024-11-25 16:00:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-25 16:11:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 8 0 0 0 107

🟢 2024-11-25 16:11:59 UTC Build successful.
🟢 2024-11-25 16:12:17 UTC ydbd size 2.5 GiB changed* by +31.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d17f1a merge: a8336e4 diff diff %
ydbd size 2 690 088 296 Bytes 2 690 120 072 Bytes +31.0 KiB +0.001%
ydbd stripped size 482 185 808 Bytes 482 190 352 Bytes +4.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 07:50:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92b278f has started.
⚪ 2024-11-27 07:50:40 UTC Artifacts will be uploaded here
⚪ 2024-11-27 07:53:46 UTC ya make is running...
🟢 2024-11-27 08:43:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20314 18804 0 0 1396 114

🟢 2024-11-27 08:45:17 UTC Build successful.
🟢 2024-11-27 08:45:36 UTC ydbd size 2.5 GiB changed* by +27.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 40b58a4 merge: 92b278f diff diff %
ydbd size 2 694 101 816 Bytes 2 694 130 128 Bytes +27.6 KiB +0.001%
ydbd stripped size 482 087 952 Bytes 482 091 408 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 07:50:41 UTC Pre-commit check linux-x86_64-release-asan for 92b278f has started.
⚪ 2024-11-27 07:50:52 UTC Artifacts will be uploaded here
⚪ 2024-11-27 07:54:00 UTC ya make is running...
🟡 2024-11-27 09:00:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12830 12754 0 21 8 47

🟢 2024-11-27 09:01:31 UTC Build successful.
🟢 2024-11-27 09:01:59 UTC ydbd size 4.9 GiB changed* by -784 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e92e224 merge: 92b278f diff diff %
ydbd size 5 293 136 232 Bytes 5 293 135 448 Bytes -784 Bytes -0.000%
ydbd stripped size 1 360 788 144 Bytes 1 360 788 016 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 11:59:21 UTC Pre-commit check linux-x86_64-release-asan for e124bda has started.
⚪ 2024-11-27 11:59:32 UTC Artifacts will be uploaded here
⚪ 2024-11-27 12:02:26 UTC ya make is running...
🟡 2024-11-27 13:11:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12842 12778 0 11 9 44

🟢 2024-11-27 13:12:37 UTC Build successful.
🟢 2024-11-27 13:13:06 UTC ydbd size 4.9 GiB changed* by +67.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d6aa89c merge: e124bda diff diff %
ydbd size 5 293 592 392 Bytes 5 293 660 976 Bytes +67.0 KiB +0.001%
ydbd stripped size 1 360 890 064 Bytes 1 360 901 808 Bytes +11.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 12:01:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for e124bda has started.
⚪ 2024-11-27 12:01:51 UTC Artifacts will be uploaded here
⚪ 2024-11-27 12:04:43 UTC ya make is running...
🟢 2024-11-27 12:53:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20326 18818 0 0 1396 112

🟢 2024-11-27 12:55:07 UTC Build successful.
🟢 2024-11-27 12:55:25 UTC ydbd size 2.5 GiB changed* by -3.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b4d276d merge: e124bda diff diff %
ydbd size 2 694 386 456 Bytes 2 694 382 896 Bytes -3.5 KiB -0.000%
ydbd stripped size 482 132 528 Bytes 482 132 464 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen merged commit dda2bc2 into ydb-platform:main Nov 29, 2024
10 checks passed
@StekPerepolnen StekPerepolnen deleted the viewer-redirect-2 branch November 29, 2024 10:07
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Open
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
@StekPerepolnen StekPerepolnen changed the title Viewer returns Failed to resolve database Fix UI error "Failed to resolve database" Dec 5, 2024
StekPerepolnen added a commit to StekPerepolnen/ydb that referenced this pull request Dec 6, 2024
@StekPerepolnen @alexv-smirnov @Raubzeug
Viewer returns Failed to resolve database (ydb-platform#11841)
46c0026 
Co-authored-by: AlexSm <[email protected]>
Co-authored-by: Raubzeug <[email protected]>
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StekPerepolnen @adameat @alexv-smirnov