Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream lookup bytes calculation #12026

Merged

Conversation

gridnevvvit
Copy link
Member

Changelog entry

fix stream lookup bytes calculation. using cellvec size estimation in read bytes

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 16:53:18 UTC Pre-commit check linux-x86_64-release-asan for d68f8cf has started.
2024-11-26 16:53:29 UTC Artifacts will be uploaded here
2024-11-26 16:56:24 UTC ya make is running...
🟡 2024-11-26 17:58:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9067 9004 0 10 5 48

🟢 2024-11-26 17:59:39 UTC Build successful.
🟢 2024-11-26 18:00:04 UTC ydbd size 4.9 GiB changed* by +240 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0a9693f merge: d68f8cf diff diff %
ydbd size 5 293 855 752 Bytes 5 293 855 992 Bytes +240 Bytes +0.000%
ydbd stripped size 1 361 407 056 Bytes 1 361 407 184 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 16:55:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for d68f8cf has started.
2024-11-26 16:55:37 UTC Artifacts will be uploaded here
2024-11-26 16:58:33 UTC ya make is running...
🟡 2024-11-26 17:49:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15481 13973 0 1 1396 111

2024-11-26 17:51:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-26 18:02:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 4 0 0 1 108

🟢 2024-11-26 18:02:32 UTC Build successful.
🟢 2024-11-26 18:02:51 UTC ydbd size 2.5 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a9693f merge: d68f8cf diff diff %
ydbd size 2 694 619 000 Bytes 2 694 619 000 Bytes 0 Bytes 0.000%
ydbd stripped size 482 600 784 Bytes 482 600 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ulya-sidorina
ulya-sidorina previously approved these changes Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 22:01:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for aeb3121 has started.
2024-11-26 22:01:46 UTC Artifacts will be uploaded here
2024-11-26 22:04:40 UTC ya make is running...
🟡 2024-11-26 22:54:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20886 19328 0 5 1440 113

2024-11-26 22:56:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-26 23:07:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
820 (only retried tests) 712 0 2 0 106

2024-11-26 23:07:36 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-26 23:18:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
626 (only retried tests) 520 0 0 0 106

🟢 2024-11-26 23:19:07 UTC Build successful.
🟢 2024-11-26 23:19:28 UTC ydbd size 2.5 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 40b58a4 merge: aeb3121 diff diff %
ydbd size 2 694 101 816 Bytes 2 694 101 992 Bytes +176 Bytes +0.000%
ydbd stripped size 482 087 952 Bytes 482 088 080 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 22:01:59 UTC Pre-commit check linux-x86_64-release-asan for aeb3121 has started.
2024-11-26 22:02:10 UTC Artifacts will be uploaded here
2024-11-26 22:05:05 UTC ya make is running...
🟡 2024-11-26 23:18:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13202 13132 0 16 5 49

🟢 2024-11-26 23:19:57 UTC Build successful.
🟢 2024-11-26 23:20:23 UTC ydbd size 4.9 GiB changed* by +240 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 40b58a4 merge: aeb3121 diff diff %
ydbd size 5 293 078 656 Bytes 5 293 078 896 Bytes +240 Bytes +0.000%
ydbd stripped size 1 360 778 416 Bytes 1 360 778 544 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit force-pushed the fix-stream-lookup-bytes-calculation branch from 774044a to b001939 Compare November 27, 2024 09:16
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 09:19:55 UTC Pre-commit check linux-x86_64-release-asan for 144e0e0 has started.
2024-11-27 09:20:06 UTC Artifacts will be uploaded here
2024-11-27 09:22:59 UTC ya make is running...
🟡 2024-11-27 10:31:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13211 13108 0 49 6 48

🟢 2024-11-27 10:32:40 UTC Build successful.
🟢 2024-11-27 10:33:11 UTC ydbd size 4.9 GiB changed* by +272 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: cb1675a merge: 144e0e0 diff diff %
ydbd size 5 293 301 104 Bytes 5 293 301 376 Bytes +272 Bytes +0.000%
ydbd stripped size 1 360 826 960 Bytes 1 360 827 216 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 09:20:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 144e0e0 has started.
2024-11-27 09:20:25 UTC Artifacts will be uploaded here
2024-11-27 09:23:19 UTC ya make is running...
🟡 2024-11-27 10:12:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20895 19352 0 34 1395 114

2024-11-27 10:14:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-27 10:25:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
972 (only retried tests) 832 0 33 0 107

2024-11-27 10:26:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-27 10:37:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
806 (only retried tests) 667 0 33 0 106

🟢 2024-11-27 10:37:46 UTC Build successful.
🟢 2024-11-27 10:38:09 UTC ydbd size 2.5 GiB changed* by +336 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: cb1675a merge: 144e0e0 diff diff %
ydbd size 2 694 204 392 Bytes 2 694 204 728 Bytes +336 Bytes +0.000%
ydbd stripped size 482 104 368 Bytes 482 104 560 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ssmike
ssmike previously approved these changes Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 22:57:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28f8aa4 has started.
2024-11-27 22:57:20 UTC Artifacts will be uploaded here
2024-11-27 23:00:27 UTC ya make is running...
🟡 2024-11-27 23:49:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20906 19388 0 1 1396 121

2024-11-27 23:51:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 00:03:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
783 (only retried tests) 677 0 0 0 106

🟢 2024-11-28 00:03:15 UTC Build successful.
🟢 2024-11-28 00:03:35 UTC ydbd size 2.5 GiB changed* by +992 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4559701 merge: 28f8aa4 diff diff %
ydbd size 2 694 960 976 Bytes 2 694 961 968 Bytes +992 Bytes +0.000%
ydbd stripped size 482 189 008 Bytes 482 189 392 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 22:57:30 UTC Pre-commit check linux-x86_64-release-asan for 28f8aa4 has started.
2024-11-27 22:57:42 UTC Artifacts will be uploaded here
2024-11-27 23:00:42 UTC ya make is running...
🟡 2024-11-28 00:08:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13222 13141 0 22 11 48

🟢 2024-11-28 00:09:51 UTC Build successful.
🟢 2024-11-28 00:10:21 UTC ydbd size 4.9 GiB changed* by +2.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4559701 merge: 28f8aa4 diff diff %
ydbd size 5 294 725 288 Bytes 5 294 727 352 Bytes +2.0 KiB +0.000%
ydbd stripped size 1 361 117 168 Bytes 1 361 117 936 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 02c6b58 into ydb-platform:main Nov 28, 2024
10 checks passed
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Nov 28, 2024
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Nov 28, 2024
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Nov 28, 2024
@gridnevvvit gridnevvvit deleted the fix-stream-lookup-bytes-calculation branch January 21, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants