Add GetBlock request #12431

mregrock · 2024-12-09T16:59:37Z

Changelog entry

Implement GetBlockRequest

Changelog category

New feature

Additional information

...

github-actions · 2024-12-09T17:01:44Z

⚪ 2024-12-09 17:01:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for c5ca30a has started.
⚪ 2024-12-09 17:01:55 UTC Artifacts will be uploaded here
⚪ 2024-12-09 17:05:16 UTC ya make is running...
⚫ 2024-12-09 17:06:29 UTC Check cancelled

github-actions · 2024-12-09T17:02:23Z

⚪ 2024-12-09 17:02:23 UTC Pre-commit check linux-x86_64-release-asan for c5ca30a has started.
⚪ 2024-12-09 17:03:00 UTC Artifacts will be uploaded here
⚫ 2024-12-09 17:06:27 UTC Check cancelled

github-actions · 2024-12-09T17:08:28Z

⚪ 2024-12-09 17:08:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for bc7d7dd has started.
⚪ 2024-12-09 17:08:32 UTC Artifacts will be uploaded here
⚪ 2024-12-09 17:11:50 UTC ya make is running...
🔴 2024-12-09 17:26:03 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-12-09T17:10:15Z

⚪ 2024-12-09 17:10:14 UTC Pre-commit check linux-x86_64-release-asan for bc7d7dd has started.
⚪ 2024-12-09 17:10:48 UTC Artifacts will be uploaded here
⚪ 2024-12-09 17:14:37 UTC ya make is running...
🔴 2024-12-09 17:23:23 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-12-09T18:16:25Z

⚪ 2024-12-09 18:16:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for b9845ba has started.
⚪ 2024-12-09 18:16:35 UTC Artifacts will be uploaded here
⚪ 2024-12-09 18:19:55 UTC ya make is running...
🟡 2024-12-09 19:17:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33088	30256	0	3	2720	109

⚪ 2024-12-09 19:20:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-09 19:31:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
636 (only retried tests)	529	0	0	0	107

🟢 2024-12-09 19:32:07 UTC Build successful.
🟢 2024-12-09 19:32:25 UTC ydbd size 2.5 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc4cb53`	merge: `b9845ba`	diff	diff %
ydbd size	2 699 242 976 Bytes	2 699 251 296 Bytes	+8.1 KiB	+0.000%
ydbd stripped size	483 484 112 Bytes	483 484 240 Bytes	+128 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-09T18:16:25Z

⚪ 2024-12-09 18:16:25 UTC Pre-commit check linux-x86_64-release-asan for b9845ba has started.
⚪ 2024-12-09 18:16:37 UTC Artifacts will be uploaded here
⚪ 2024-12-09 18:20:05 UTC ya make is running...
🟡 2024-12-09 19:28:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15539	15464	0	23	6	46

🟢 2024-12-09 19:30:13 UTC Build successful.
🟢 2024-12-09 19:30:41 UTC ydbd size 4.9 GiB changed* by +38.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc4cb53`	merge: `b9845ba`	diff	diff %
ydbd size	5 305 425 728 Bytes	5 305 465 328 Bytes	+38.7 KiB	+0.001%
ydbd stripped size	1 365 508 016 Bytes	1 365 518 288 Bytes	+10.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

alexvru

Add at least one test that it works.
Also it would be good to check if it works when some disks have failed.

ydb/core/base/blobstorage.h

ydb/core/blobstorage/dsproxy/dsproxy_get_block.cpp

github-actions · 2024-12-10T08:36:31Z

⚪ 2024-12-10 08:36:30 UTC Pre-commit check linux-x86_64-release-asan for 68a6f65 has started.
⚪ 2024-12-10 08:36:41 UTC Artifacts will be uploaded here
⚪ 2024-12-10 08:40:03 UTC ya make is running...
🟡 2024-12-10 10:19:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15591	15523	0	16	6	46

🟢 2024-12-10 10:20:38 UTC Build successful.
🟢 2024-12-10 10:21:06 UTC ydbd size 4.9 GiB changed* by +83.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d299ffe`	merge: `68a6f65`	diff	diff %
ydbd size	5 291 385 840 Bytes	5 291 471 768 Bytes	+83.9 KiB	+0.002%
ydbd stripped size	1 365 606 032 Bytes	1 365 621 680 Bytes	+15.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-10T08:37:38Z

⚪ 2024-12-10 08:37:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 68a6f65 has started.
⚪ 2024-12-10 08:37:48 UTC Artifacts will be uploaded here
⚪ 2024-12-10 08:41:09 UTC ya make is running...
🟡 2024-12-10 10:10:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33142	30301	0	5	2725	111

⚪ 2024-12-10 10:13:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-10 10:24:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
650 (only retried tests)	541	0	2	0	107

⚪ 2024-12-10 10:24:55 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-10 10:36:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
638 (only retried tests)	529	0	2	0	107

🟢 2024-12-10 10:36:35 UTC Build successful.
🟢 2024-12-10 10:36:56 UTC ydbd size 2.5 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `456154d`	merge: `68a6f65`	diff	diff %
ydbd size	2 690 733 968 Bytes	2 690 745 808 Bytes	+11.6 KiB	+0.000%
ydbd stripped size	483 523 760 Bytes	483 524 336 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-10T12:52:32Z

⚪ 2024-12-10 12:52:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for cd4c4b3 has started.
⚪ 2024-12-10 12:52:44 UTC Artifacts will be uploaded here
⚪ 2024-12-10 12:56:04 UTC ya make is running...
🟢 2024-12-10 14:30:30 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33166	30323	0	0	2728	115

🟢 2024-12-10 14:34:12 UTC Build successful.
🟡 2024-12-10 14:34:27 UTC ydbd size 2.1 GiB changed* by +239.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `137077a`	merge: `cd4c4b3`	diff	diff %
ydbd size	2 254 497 152 Bytes	2 254 742 528 Bytes	+239.6 KiB	+0.011%
ydbd stripped size	483 694 480 Bytes	483 718 928 Bytes	+23.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-10T12:52:48Z

⚪ 2024-12-10 12:52:48 UTC Pre-commit check linux-x86_64-release-asan for cd4c4b3 has started.
⚪ 2024-12-10 12:53:20 UTC Artifacts will be uploaded here
⚪ 2024-12-10 12:57:12 UTC ya make is running...
🟡 2024-12-10 14:35:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15591	15508	0	29	9	45

🟢 2024-12-10 14:37:07 UTC Build successful.
🟡 2024-12-10 14:37:35 UTC ydbd size 3.6 GiB changed* by +393.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `137077a`	merge: `cd4c4b3`	diff	diff %
ydbd size	3 895 711 416 Bytes	3 896 113 920 Bytes	+393.1 KiB	+0.010%
ydbd stripped size	1 366 028 528 Bytes	1 366 101 040 Bytes	+70.8 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T10:00:26Z

⚪ 2024-12-11 10:00:25 UTC Pre-commit check linux-x86_64-release-asan for ec82424 has started.
⚪ 2024-12-11 10:00:37 UTC Artifacts will be uploaded here
⚪ 2024-12-11 10:04:09 UTC ya make is running...
🟡 2024-12-11 11:46:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15608	15525	0	27	7	49

🟢 2024-12-11 11:47:31 UTC Build successful.
🟡 2024-12-11 11:47:58 UTC ydbd size 3.6 GiB changed* by +697.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e838a62`	merge: `ec82424`	diff	diff %
ydbd size	3 897 699 800 Bytes	3 898 414 056 Bytes	+697.5 KiB	+0.018%
ydbd stripped size	1 366 522 384 Bytes	1 366 694 928 Bytes	+168.5 KiB	+0.013%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T10:00:27Z

⚪ 2024-12-11 10:00:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec82424 has started.
⚪ 2024-12-11 10:00:37 UTC Artifacts will be uploaded here
⚪ 2024-12-11 10:03:58 UTC ya make is running...
🟡 2024-12-11 11:31:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33195	30265	0	1	2813	116

⚪ 2024-12-11 11:34:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 11:45:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
680 (only retried tests)	571	0	2	0	107

⚪ 2024-12-11 11:46:02 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 11:57:30 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
638 (only retried tests)	530	0	1	0	107

🟢 2024-12-11 11:57:39 UTC Build successful.
🟡 2024-12-11 11:58:00 UTC ydbd size 2.1 GiB changed* by +409.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e838a62`	merge: `ec82424`	diff	diff %
ydbd size	2 255 721 664 Bytes	2 256 140 448 Bytes	+409.0 KiB	+0.019%
ydbd stripped size	483 873 296 Bytes	483 924 624 Bytes	+50.1 KiB	+0.011%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

maximyurchuk · 2024-12-11T12:45:34Z

Залил по ошибке, сорри (это не требовалось)

github-actions bot added the new-feature label Dec 9, 2024

mregrock force-pushed the get_block_request branch from 312d080 to d79000d Compare December 9, 2024 17:06

mregrock force-pushed the get_block_request branch from d79000d to beda8df Compare December 9, 2024 18:15

alexvru requested changes Dec 10, 2024

View reviewed changes

mregrock force-pushed the get_block_request branch 2 times, most recently from 967e4e4 to 6bb8ff3 Compare December 10, 2024 08:34

mregrock force-pushed the get_block_request branch from 6bb8ff3 to 21340ae Compare December 10, 2024 12:49

Add GetBlock request

e04f02f

mregrock force-pushed the get_block_request branch from 21340ae to e04f02f Compare December 11, 2024 09:56

maximyurchuk merged commit 4ca0cb6 into ydb-platform:main Dec 11, 2024
7 of 10 checks passed

GrigoriyPA mentioned this pull request Dec 18, 2024

YQ-3975 RD fixed fault for parsing errors without filter #12707

Merged

niksaveliev mentioned this pull request Dec 25, 2024

Kafka connect distributed #12960

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GetBlock request #12431

Add GetBlock request #12431

mregrock commented Dec 9, 2024

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

alexvru left a comment

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

maximyurchuk commented Dec 11, 2024

Add GetBlock request #12431

Add GetBlock request #12431

Conversation

mregrock commented Dec 9, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

alexvru left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

maximyurchuk commented Dec 11, 2024

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading