YQ-3955-RD fixed field ids error

[GrigoriyPA]

Changelog entry

Fixed field ids error

Changelog category

• Bugfix

Additional information

[github-actions]

⚪ 2024-12-10 10:58:28 UTC Pre-commit check linux-x86_64-release-asan for 41cd98f has started.
⚪ 2024-12-10 10:58:38 UTC Artifacts will be uploaded here
⚪ 2024-12-10 11:01:32 UTC ya make is running...
🟡 2024-12-10 12:02:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
13017	12947	0	20	6	44

🟢 2024-12-10 12:04:05 UTC Build successful.
🟡 2024-12-10 12:04:33 UTC ydbd size 4.9 GiB changed* by +120.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: 5b2927c	merge: 41cd98f	diff	diff %
ydbd size	5 291 168 144 Bytes	5 291 291 864 Bytes	+120.8 KiB	+0.002%
ydbd stripped size	1 365 608 656 Bytes	1 365 637 200 Bytes	+27.9 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-12-10 10:58:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 41cd98f has started.
⚪ 2024-12-10 10:59:05 UTC Artifacts will be uploaded here
⚪ 2024-12-10 11:02:10 UTC ya make is running...
🟡 2024-12-10 12:00:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
30192	27353	0	4	2721	114

⚪ 2024-12-10 12:02:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-10 12:14:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
830 (only retried tests)	722	0	0	1	107

🟢 2024-12-10 12:14:33 UTC Build successful.
🟢 2024-12-10 12:14:53 UTC ydbd size 2.5 GiB changed* by +40 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: 68a09a0	merge: 41cd98f	diff	diff %
ydbd size	2 690 605 840 Bytes	2 690 605 880 Bytes	+40 Bytes	+0.000%
ydbd stripped size	483 520 944 Bytes	483 520 944 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[dorooleg]

А почему этот if ушел, ничего не сломает?

[GrigoriyPA]

DoParsing(true) как оказалось опасная штука, её надо вызывать аккуратно, оставил её только в одном месте:

ydb/ydb/core/fq/libs/row_dispatcher/topic_session.cpp

Lines 835 to 838 in 0304265

	if (Parser) {
	// Parse remains data before adding new client
	DoParsing(true);
	}

Это нужно делать только перед обновлением парсера в UpdateParser(), при этом все клиенты должны быть готовы к тому, что сейчас в них польются данные со старой схемой, по этому раньше падало (данные со старой схемой шли в новых клиентов)

[GrigoriyPA]

Теперь парсер будет обновляться сразу, как только добавился клиент, так будет проще, стабильнее и ошибки будут быстрее валидироваться