Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize memory allocation for schema versions on init #12533

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Dec 11, 2024

Changelog entry

Optimize memory allocation for schema versions on CS init

Changelog category

  • Improvement
  • Performance improvement

Additional information

...

@swalrus1 swalrus1 linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 11, 2024

2024-12-11 18:08:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for de47558 has started.
2024-12-11 18:09:02 UTC Artifacts will be uploaded here
2024-12-11 18:12:09 UTC ya make is running...
🔴 2024-12-11 19:54:19 UTC Too many tests failed, NOT going to retry
🔴 2024-12-11 19:56:54 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21045 18900 0 626 1405 114

🟢 2024-12-11 19:59:11 UTC Build successful.
🟢 2024-12-11 19:59:29 UTC ydbd size 2.1 GiB changed* by -23.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 974cc86 merge: de47558 diff diff %
ydbd size 2 256 248 872 Bytes 2 256 224 968 Bytes -23.3 KiB -0.001%
ydbd stripped size 483 942 864 Bytes 483 939 280 Bytes -3.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 11, 2024

2024-12-11 18:08:29 UTC Pre-commit check linux-x86_64-release-asan for de47558 has started.
2024-12-11 18:08:40 UTC Artifacts will be uploaded here
2024-12-11 18:11:35 UTC ya make is running...
🔴 2024-12-11 19:18:07 UTC Too many tests failed, NOT going to retry
🟡 2024-12-11 19:19:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13316 12719 0 545 6 46

🟢 2024-12-11 19:20:58 UTC Build successful.
🟢 2024-12-11 19:21:23 UTC ydbd size 3.6 GiB changed* by -27.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 974cc86 merge: de47558 diff diff %
ydbd size 3 898 601 272 Bytes 3 898 573 128 Bytes -27.5 KiB -0.001%
ydbd stripped size 1 366 742 576 Bytes 1 366 732 464 Bytes -9.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 08:20:15 UTC Pre-commit check linux-x86_64-release-asan for fc6e924 has started.
2024-12-12 08:22:25 UTC Artifacts will be uploaded here
2024-12-12 08:25:52 UTC ya make is running...
2024-12-12 08:36:22 UTC Check cancelled

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 08:21:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc6e924 has started.
2024-12-12 08:22:41 UTC Artifacts will be uploaded here
2024-12-12 08:26:08 UTC ya make is running...
2024-12-12 08:36:22 UTC Check cancelled

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 08:38:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 95366d6 has started.
2024-12-12 08:38:34 UTC Artifacts will be uploaded here
2024-12-12 08:41:43 UTC ya make is running...
🟡 2024-12-12 09:36:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21045 19455 0 69 1406 115

2024-12-12 09:38:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 09:51:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
953 (only retried tests) 775 0 68 1 109

2024-12-12 09:51:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 10:03:34 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
876 (only retried tests) 701 0 68 0 107

🟢 2024-12-12 10:03:45 UTC Build successful.
🟢 2024-12-12 10:04:06 UTC ydbd size 2.1 GiB changed* by -26.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 251a022 merge: 95366d6 diff diff %
ydbd size 2 256 177 432 Bytes 2 256 150 184 Bytes -26.6 KiB -0.001%
ydbd stripped size 483 924 912 Bytes 483 917 360 Bytes -7.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 08:39:19 UTC Pre-commit check linux-x86_64-release-asan for 95366d6 has started.
2024-12-12 08:39:30 UTC Artifacts will be uploaded here
2024-12-12 08:42:26 UTC ya make is running...
🟡 2024-12-12 09:44:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13317 13189 0 78 4 46

🟢 2024-12-12 09:46:03 UTC Build successful.
🟢 2024-12-12 09:46:28 UTC ydbd size 3.6 GiB changed* by -16.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 95f1072 merge: 95366d6 diff diff %
ydbd size 3 898 441 552 Bytes 3 898 425 168 Bytes -16.0 KiB -0.000%
ydbd stripped size 1 366 674 160 Bytes 1 366 662 704 Bytes -11.2 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 11:07:39 UTC Pre-commit check linux-x86_64-release-asan for eb23e89 has started.
2024-12-12 11:07:50 UTC Artifacts will be uploaded here
2024-12-12 11:10:57 UTC ya make is running...
🟡 2024-12-12 12:19:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13317 13236 0 30 6 45

🟢 2024-12-12 12:20:12 UTC Build successful.
🟢 2024-12-12 12:20:37 UTC ydbd size 3.6 GiB changed* by -21.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: cfe8084 merge: eb23e89 diff diff %
ydbd size 3 898 471 608 Bytes 3 898 449 840 Bytes -21.3 KiB -0.001%
ydbd stripped size 1 366 681 136 Bytes 1 366 670 768 Bytes -10.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 11:10:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for eb23e89 has started.
2024-12-12 11:10:25 UTC Artifacts will be uploaded here
2024-12-12 11:13:28 UTC ya make is running...
🟡 2024-12-12 12:06:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21045 19518 0 6 1406 115

2024-12-12 12:08:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 12:20:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
787 (only retried tests) 677 0 1 0 109

2024-12-12 12:20:28 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 12:36:14 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
740 (only retried tests) 632 0 1 0 107

🟢 2024-12-12 12:36:28 UTC Build successful.
🟢 2024-12-12 12:36:49 UTC ydbd size 2.1 GiB changed* by -23.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: cfe8084 merge: eb23e89 diff diff %
ydbd size 2 256 186 696 Bytes 2 256 163 168 Bytes -23.0 KiB -0.001%
ydbd stripped size 483 926 448 Bytes 483 919 408 Bytes -6.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 13:27:19 UTC Pre-commit check linux-x86_64-release-asan for 5783da2 has started.
2024-12-12 13:27:30 UTC Artifacts will be uploaded here
2024-12-12 13:30:27 UTC ya make is running...
🟡 2024-12-12 14:36:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13329 13258 0 18 6 47

🟢 2024-12-12 14:37:26 UTC Build successful.
🟢 2024-12-12 14:37:51 UTC ydbd size 3.6 GiB changed* by -21.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d78c86c merge: 5783da2 diff diff %
ydbd size 3 898 615 992 Bytes 3 898 594 216 Bytes -21.3 KiB -0.001%
ydbd stripped size 1 366 738 000 Bytes 1 366 727 632 Bytes -10.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 13:27:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5783da2 has started.
2024-12-12 13:27:58 UTC Artifacts will be uploaded here
2024-12-12 13:30:54 UTC ya make is running...
🟡 2024-12-12 14:23:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21057 19442 0 5 1496 114

2024-12-12 14:24:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-12 14:36:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
791 (only retried tests) 684 0 0 0 107

🟢 2024-12-12 14:36:47 UTC Build successful.
🟢 2024-12-12 14:37:05 UTC ydbd size 2.1 GiB changed* by -19.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d78c86c merge: 5783da2 diff diff %
ydbd size 2 256 263 536 Bytes 2 256 244 096 Bytes -19.0 KiB -0.001%
ydbd stripped size 483 943 952 Bytes 483 941 008 Bytes -2.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review December 12, 2024 15:37
@swalrus1 swalrus1 requested a review from a team as a code owner December 12, 2024 15:37
Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 17:35:17 UTC Pre-commit check linux-x86_64-release-asan for ad41bff has started.
2024-12-12 17:35:28 UTC Artifacts will be uploaded here
2024-12-12 17:38:24 UTC ya make is running...
🟡 2024-12-12 18:47:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13330 13261 0 17 5 47

🟢 2024-12-12 18:48:28 UTC Build successful.
🟢 2024-12-12 18:48:51 UTC ydbd size 3.6 GiB changed* by -19.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9c831b2 merge: ad41bff diff diff %
ydbd size 3 899 143 392 Bytes 3 899 123 024 Bytes -19.9 KiB -0.001%
ydbd stripped size 1 366 849 872 Bytes 1 366 840 080 Bytes -9.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 17:35:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for ad41bff has started.
2024-12-12 17:35:36 UTC Artifacts will be uploaded here
2024-12-12 17:38:40 UTC ya make is running...
🟡 2024-12-12 18:33:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20831 19300 0 8 1409 114

2024-12-12 18:35:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-12 18:46:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
692 (only retried tests) 584 0 0 0 108

🟢 2024-12-12 18:46:59 UTC Build successful.
🟢 2024-12-12 18:47:17 UTC ydbd size 2.1 GiB changed* by -15.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d779ea8 merge: ad41bff diff diff %
ydbd size 2 256 581 968 Bytes 2 256 566 000 Bytes -15.6 KiB -0.001%
ydbd stripped size 484 008 560 Bytes 484 005 744 Bytes -2.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit 7a1a682 into ydb-platform:main Dec 12, 2024
11 checks passed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce memory consumption on CS initialization
2 participants