Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blobs fetcher unification #12858

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 08:46:18 UTC Pre-commit check linux-x86_64-release-asan for 5c5ee78 has started.
2024-12-21 08:46:30 UTC Artifacts will be uploaded here
🔴 2024-12-21 08:48:30 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 08:46:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c5ee78 has started.
2024-12-21 08:46:32 UTC Artifacts will be uploaded here
🔴 2024-12-21 08:48:30 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 09:03:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for c02523a has started.
2024-12-21 09:04:10 UTC Artifacts will be uploaded here
🔴 2024-12-21 09:06:07 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 09:04:11 UTC Pre-commit check linux-x86_64-release-asan for c02523a has started.
2024-12-21 09:04:23 UTC Artifacts will be uploaded here
🔴 2024-12-21 09:06:21 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 10:06:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab25093 has started.
2024-12-21 10:06:53 UTC Artifacts will be uploaded here
2024-12-21 10:09:46 UTC ya make is running...
🟡 2024-12-21 11:00:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19019 17487 0 1 1416 115

2024-12-21 11:23:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-21 11:35:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 52 0 0 0 110

🟢 2024-12-21 11:35:31 UTC Build successful.
🟢 2024-12-21 11:35:48 UTC ydbd size 2.1 GiB changed* by -45.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: ab25093 diff diff %
ydbd size 2 235 522 680 Bytes 2 235 476 632 Bytes -45.0 KiB -0.002%
ydbd stripped size 477 900 048 Bytes 477 900 176 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 21, 2024

2024-12-21 10:06:56 UTC Pre-commit check linux-x86_64-release-asan for ab25093 has started.
2024-12-21 10:07:07 UTC Artifacts will be uploaded here
2024-12-21 10:10:05 UTC ya make is running...
🟡 2024-12-21 11:17:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12045 11968 0 23 11 43

🟢 2024-12-21 11:23:36 UTC Build successful.
🟢 2024-12-21 11:23:59 UTC ydbd size 3.6 GiB changed* by -43.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: ab25093 diff diff %
ydbd size 3 866 166 992 Bytes 3 866 122 928 Bytes -43.0 KiB -0.001%
ydbd stripped size 1 350 424 112 Bytes 1 350 410 416 Bytes -13.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 23, 2024 07:28
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 23, 2024 07:28
@ivanmorozov333 ivanmorozov333 merged commit c6318e6 into ydb-platform:main Dec 23, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the unify_blobs_constructor branch December 23, 2024 07:28
asmyasnikov pushed a commit to asmyasnikov/ydb that referenced this pull request Dec 23, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants