Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream lookup: GetRangePartitioning() optimization #13180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zinal
Copy link
Member

@zinal zinal commented Jan 5, 2025

Changelog entry

...

Changelog category

  • Performance improvement
  • Not for changelog (changelog entry is not required)

Additional information

...

@zinal
Copy link
Member Author

zinal commented Jan 5, 2025

According to measurements, this gives extra 20% of saved execution time (after applying fix from #13174) for large index-based range scan queries.

Copy link

github-actions bot commented Jan 5, 2025

2025-01-05 15:44:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9ba26d has started.
2025-01-05 15:44:21 UTC Artifacts will be uploaded here
2025-01-05 15:47:18 UTC ya make is running...
🟡 2025-01-05 16:32:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18696 17352 0 48 1169 127

2025-01-05 16:33:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-05 16:45:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
280 (only retried tests) 112 0 44 0 124

2025-01-05 16:45:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-05 16:57:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
268 (only retried tests) 103 0 44 0 121

🟢 2025-01-05 16:57:45 UTC Build successful.
🟢 2025-01-05 16:58:09 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7857771 merge: f9ba26d diff diff %
ydbd size 2 243 628 496 Bytes 2 243 630 760 Bytes +2.2 KiB +0.000%
ydbd stripped size 472 255 376 Bytes 472 256 144 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 5, 2025

2025-01-05 15:44:08 UTC Pre-commit check linux-x86_64-release-asan for f9ba26d has started.
2025-01-05 15:44:20 UTC Artifacts will be uploaded here
2025-01-05 15:47:15 UTC ya make is running...
🟡 2025-01-05 16:44:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11581 11475 0 71 7 28

2025-01-05 16:46:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-05 16:58:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 118 0 46 0 27

2025-01-05 16:58:53 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-05 17:10:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
141 (only retried tests) 72 0 44 1 24

🟢 2025-01-05 17:10:44 UTC Build successful.
🟢 2025-01-05 17:11:15 UTC ydbd size 3.6 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7857771 merge: f9ba26d diff diff %
ydbd size 3 872 738 736 Bytes 3 872 740 304 Bytes +1.5 KiB +0.000%
ydbd stripped size 1 350 441 072 Bytes 1 350 441 424 Bytes +352 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 6, 2025

2025-01-06 07:24:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for aaefe21 has started.
2025-01-06 07:25:00 UTC Artifacts will be uploaded here
2025-01-06 07:27:53 UTC ya make is running...
🟡 2025-01-06 08:12:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18698 17396 0 3 1169 130

2025-01-06 08:14:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-06 08:26:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 71 0 0 0 125

🟢 2025-01-06 08:26:40 UTC Build successful.
🟢 2025-01-06 08:27:01 UTC ydbd size 2.1 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: baa0367 merge: aaefe21 diff diff %
ydbd size 2 243 630 416 Bytes 2 243 633 224 Bytes +2.7 KiB +0.000%
ydbd stripped size 472 255 824 Bytes 472 256 784 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 6, 2025

2025-01-06 07:25:56 UTC Pre-commit check linux-x86_64-release-asan for aaefe21 has started.
2025-01-06 07:26:00 UTC Artifacts will be uploaded here
2025-01-06 07:28:49 UTC ya make is running...
🟡 2025-01-06 08:23:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11583 11529 0 21 2 31

2025-01-06 08:24:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-06 08:36:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
91 (only retried tests) 59 0 5 0 27

2025-01-06 08:36:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-06 08:48:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 29 0 3 0 27

🟢 2025-01-06 08:48:36 UTC Build successful.
🟢 2025-01-06 08:49:02 UTC ydbd size 3.6 GiB changed* by +3.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: baa0367 merge: aaefe21 diff diff %
ydbd size 3 872 742 784 Bytes 3 872 746 128 Bytes +3.3 KiB +0.000%
ydbd stripped size 1 350 442 672 Bytes 1 350 443 728 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant