Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed short blobs in TCell, fix empty string #13194

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Embed short blobs in TCell, fix empty string #13194

merged 2 commits into from
Jan 9, 2025

Conversation

zverevgeny
Copy link
Collaborator

Changelog category

  • Bugfix

@github-actions github-actions bot added the bugfix label Jan 7, 2025
@zverevgeny zverevgeny linked an issue Jan 7, 2025 that may be closed by this pull request
Error while inserting empty NOT NULL string #13052
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 16:58:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for bbf11bb has started.
⚪ 2025-01-07 16:58:58 UTC Artifacts will be uploaded here
⚪ 2025-01-07 17:01:49 UTC ya make is running...
⚫ 2025-01-07 17:21:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 16:58:55 UTC Pre-commit check linux-x86_64-release-asan for bbf11bb has started.
⚪ 2025-01-07 16:59:07 UTC Artifacts will be uploaded here
⚪ 2025-01-07 17:01:57 UTC ya make is running...
⚫ 2025-01-07 17:21:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 17:22:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ad2155 has started.
⚪ 2025-01-07 17:24:27 UTC Artifacts will be uploaded here
⚪ 2025-01-07 17:28:03 UTC ya make is running...
🟡 2025-01-07 18:11:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18704 17398 0 13 1169 124

⚪ 2025-01-07 18:12:59 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 18:24:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 78 0 2 0 118

⚪ 2025-01-07 18:25:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-07 18:36:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 57 0 0 0 117

🟢 2025-01-07 18:36:38 UTC Build successful.
🟢 2025-01-07 18:37:00 UTC ydbd size 2.1 GiB changed* by +912 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5299845 merge: 7ad2155 diff diff %
ydbd size 2 244 179 536 Bytes 2 244 180 448 Bytes +912 Bytes +0.000%
ydbd stripped size 472 316 464 Bytes 472 316 848 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny changed the title Fix empty string Embed short blobs in TCell, fix empty string Jan 7, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

⚪ 2025-01-07 17:25:01 UTC Pre-commit check linux-x86_64-release-asan for 7ad2155 has started.
⚪ 2025-01-07 17:25:14 UTC Artifacts will be uploaded here
⚪ 2025-01-07 17:28:07 UTC ya make is running...
🟡 2025-01-07 18:30:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11585 11500 0 51 6 28

⚪ 2025-01-07 18:31:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 18:43:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 108 0 5 1 24

⚪ 2025-01-07 18:44:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-07 18:55:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 29 0 3 1 22

🟢 2025-01-07 18:55:37 UTC Build successful.
🟢 2025-01-07 18:56:07 UTC ydbd size 3.6 GiB changed* by -144 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5299845 merge: 7ad2155 diff diff %
ydbd size 3 873 618 136 Bytes 3 873 617 992 Bytes -144 Bytes -0.000%
ydbd stripped size 1 350 620 464 Bytes 1 350 620 464 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny requested a review from nikvas0 January 7, 2025 17:59
nikvas0
nikvas0 previously approved these changes Jan 8, 2025
View reviewed changes
@zverevgeny zverevgeny requested a review from nikvas0 January 8, 2025 19:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 19:43:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3056f1b has started.
⚪ 2025-01-08 19:43:27 UTC Artifacts will be uploaded here
⚪ 2025-01-08 19:46:18 UTC ya make is running...
🟡 2025-01-08 20:31:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18706 17315 0 12 1255 124

⚪ 2025-01-08 20:33:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 20:44:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
286 (only retried tests) 162 0 3 0 121

⚪ 2025-01-08 20:44:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-08 20:56:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 62 0 0 0 120

🟢 2025-01-08 20:56:23 UTC Build successful.
🟢 2025-01-08 20:56:47 UTC ydbd size 2.1 GiB changed* by +896 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9f31130 merge: 3056f1b diff diff %
ydbd size 2 244 317 464 Bytes 2 244 318 360 Bytes +896 Bytes +0.000%
ydbd stripped size 472 336 560 Bytes 472 336 944 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 19:43:42 UTC Pre-commit check linux-x86_64-release-asan for 3056f1b has started.
⚪ 2025-01-08 19:43:55 UTC Artifacts will be uploaded here
⚪ 2025-01-08 19:46:56 UTC ya make is running...
🟡 2025-01-08 20:45:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11585 11506 0 42 8 29

⚪ 2025-01-08 20:46:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 20:59:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 87 0 8 5 26

⚪ 2025-01-08 20:59:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 21:10:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 41 0 3 0 26

🟢 2025-01-08 21:11:05 UTC Build successful.
🟢 2025-01-08 21:11:37 UTC ydbd size 3.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9f31130 merge: 3056f1b diff diff %
ydbd size 3 873 834 368 Bytes 3 873 834 208 Bytes -160 Bytes -0.000%
ydbd stripped size 1 350 684 240 Bytes 1 350 684 240 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit d68c1c1 into ydb-platform:main Jan 9, 2025
12 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
@zverevgeny
Embed short blobs in TCell, fix empty string (ydb-platform#13194)
5f600f1
@zverevgeny zverevgeny mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikvas0 nikvas0 nikvas0 approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while inserting empty NOT NULL string
2 participants
@zverevgeny @nikvas0