Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading session without cursor #9246

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

fexolm
Copy link
Member

@fexolm fexolm commented Sep 13, 2024

Changelog entry

fixes #8659

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 19:26:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0411b3d has started.
2024-09-13 19:26:26 UTC Artifacts will be uploaded here
2024-09-13 19:29:08 UTC ya make is running...
🟡 2024-09-13 20:25:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14806 13105 0 8 1654 39

2024-09-13 20:27:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-13 20:36:07 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
336 (only retried tests) 241 0 0 8 87

🟢 2024-09-13 20:36:20 UTC Build successful.
🟢 2024-09-13 20:36:56 UTC ydbd size 8.4 GiB changed* by +33.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3dce9fe merge: 0411b3d diff diff %
ydbd size 9 044 518 464 Bytes 9 044 552 528 Bytes +33.3 KiB +0.000%
ydbd stripped size 488 952 072 Bytes 488 953 352 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 19:26:42 UTC Pre-commit check linux-x86_64-release-clang14 for 0411b3d has started.
2024-09-13 19:26:51 UTC Artifacts will be uploaded here
2024-09-13 19:29:37 UTC ya make is running...
🟢 2024-09-13 19:49:21 UTC Build successful.

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 19:26:58 UTC Pre-commit check linux-x86_64-release-asan for 0411b3d has started.
2024-09-13 19:27:08 UTC Artifacts will be uploaded here
2024-09-13 19:30:00 UTC ya make is running...
🔴 2024-09-13 21:20:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10366 10153 0 60 43 110

🟢 2024-09-13 21:21:50 UTC Build successful.
🟢 2024-09-13 21:22:25 UTC ydbd size 5.6 GiB changed* by +30.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3dce9fe merge: 0411b3d diff diff %
ydbd size 6 053 386 968 Bytes 6 053 418 616 Bytes +30.9 KiB +0.001%
ydbd stripped size 1 514 958 864 Bytes 1 514 963 216 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm changed the title Fexolm/fix partitioning3 Fix loading session without cursor Sep 16, 2024
@fexolm fexolm force-pushed the fexolm/fix-partitioning3 branch from 1c344f0 to 0f8543a Compare September 16, 2024 11:23
ivanmorozov333
ivanmorozov333 previously approved these changes Sep 16, 2024
@fexolm fexolm force-pushed the fexolm/fix-partitioning3 branch from 0f8543a to 3855776 Compare September 16, 2024 11:37
@fexolm fexolm marked this pull request as ready for review September 16, 2024 11:37
@fexolm fexolm requested a review from a team as a code owner September 16, 2024 11:37
Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 11:39:35 UTC Pre-commit check linux-x86_64-release-asan for c06fb42 has started.
2024-09-16 11:39:45 UTC Artifacts will be uploaded here
🔴 2024-09-16 11:41:33 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 11:39:46 UTC Pre-commit check linux-x86_64-release-clang14 for c06fb42 has started.
2024-09-16 11:39:55 UTC Artifacts will be uploaded here
🔴 2024-09-16 11:41:42 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 11:40:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for c06fb42 has started.
2024-09-16 11:40:19 UTC Artifacts will be uploaded here
🔴 2024-09-16 11:42:06 UTC Graph compare failed, see the logs.

@fexolm fexolm force-pushed the fexolm/fix-partitioning3 branch from 3855776 to 05b0256 Compare September 16, 2024 11:57
Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 12:06:40 UTC Pre-commit check linux-x86_64-release-clang14 for 49b5501 has started.
2024-09-16 12:06:56 UTC Artifacts will be uploaded here
2024-09-16 12:09:42 UTC ya make is running...
🟢 2024-09-16 12:16:38 UTC Build successful.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 12:08:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 49b5501 has started.
2024-09-16 12:08:39 UTC Artifacts will be uploaded here
2024-09-16 12:11:26 UTC ya make is running...
🟡 2024-09-16 13:11:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14824 13189 0 4 1567 64

2024-09-16 13:12:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-16 13:20:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
270 (only retried tests) 176 0 0 7 87

🟢 2024-09-16 13:20:43 UTC Build successful.
🟡 2024-09-16 13:21:24 UTC ydbd size 8.4 GiB changed* by +228.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 946e6a2 merge: 49b5501 diff diff %
ydbd size 9 031 084 480 Bytes 9 031 318 448 Bytes +228.5 KiB +0.003%
ydbd stripped size 488 804 968 Bytes 488 812 648 Bytes +7.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 12:12:32 UTC Pre-commit check linux-x86_64-release-asan for 49b5501 has started.
2024-09-16 12:12:51 UTC Artifacts will be uploaded here
2024-09-16 12:15:40 UTC ya make is running...
🔴 2024-09-16 14:02:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10375 10184 0 39 43 109

🟢 2024-09-16 14:03:47 UTC Build successful.
🟡 2024-09-16 14:04:21 UTC ydbd size 5.6 GiB changed* by +144.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 946e6a2 merge: 49b5501 diff diff %
ydbd size 6 045 727 016 Bytes 6 045 874 472 Bytes +144.0 KiB +0.002%
ydbd stripped size 1 513 221 360 Bytes 1 513 246 000 Bytes +24.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm merged commit 2c34e9f into ydb-platform:main Sep 17, 2024
10 of 12 checks passed
@fexolm fexolm deleted the fexolm/fix-partitioning3 branch September 17, 2024 12:02
@shnikd shnikd mentioned this pull request Sep 19, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify failed in NDataSharing::TSourceCursor::DeserializeFromProto
2 participants