Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partitioning for empty tables #9372

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

fexolm
Copy link
Member

@fexolm fexolm commented Sep 17, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@fexolm fexolm force-pushed the fexolm/fix-partitioning5 branch from 173a96e to d089b2a Compare September 17, 2024 12:05
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:06:21 UTC Pre-commit check linux-x86_64-release-asan for c0cd7be has started.
2024-09-17 12:06:32 UTC Artifacts will be uploaded here
2024-09-17 12:09:25 UTC ya make is running...
🔴 2024-09-17 14:07:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10376 9990 0 60 261 65

🟢 2024-09-17 14:08:30 UTC Build successful.
🟢 2024-09-17 14:09:08 UTC ydbd size 5.6 GiB changed* by -5.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e2988c2 merge: c0cd7be diff diff %
ydbd size 6 045 697 704 Bytes 6 045 692 112 Bytes -5.5 KiB -0.000%
ydbd stripped size 1 513 156 368 Bytes 1 513 155 216 Bytes -1.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:06:22 UTC Pre-commit check linux-x86_64-release-clang14 for c0cd7be has started.
2024-09-17 12:06:31 UTC Artifacts will be uploaded here
2024-09-17 12:09:17 UTC ya make is running...
🟢 2024-09-17 12:20:09 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:06:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for c0cd7be has started.
2024-09-17 12:06:40 UTC Artifacts will be uploaded here
2024-09-17 12:09:36 UTC ya make is running...
🟡 2024-09-17 13:16:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14814 13162 0 14 1368 270

2024-09-17 13:17:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 13:25:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
287 (only retried tests) 192 0 0 7 88

🟢 2024-09-17 13:25:59 UTC Build successful.
🟢 2024-09-17 13:26:37 UTC ydbd size 8.4 GiB changed* by +7.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2c34e9f merge: c0cd7be diff diff %
ydbd size 9 031 009 120 Bytes 9 031 016 504 Bytes +7.2 KiB +0.000%
ydbd stripped size 488 766 248 Bytes 488 766 376 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm marked this pull request as ready for review September 17, 2024 12:10
@fexolm fexolm requested a review from a team as a code owner September 17, 2024 12:10
ivanmorozov333
ivanmorozov333 previously approved these changes Sep 17, 2024
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 12:48:21 UTC Pre-commit check linux-x86_64-release-clang14 for 7a23dbe has started.
2024-09-18 12:48:30 UTC Artifacts will be uploaded here
2024-09-18 12:51:18 UTC ya make is running...
🟢 2024-09-18 12:57:45 UTC Build successful.

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 12:48:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7a23dbe has started.
2024-09-18 12:48:47 UTC Artifacts will be uploaded here
2024-09-18 12:51:37 UTC ya make is running...
🟡 2024-09-18 13:55:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14820 13343 0 1 1374 102

2024-09-18 13:57:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-18 14:08:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 15 0 0 1 91

🟢 2024-09-18 14:08:59 UTC Build successful.
🟢 2024-09-18 14:09:35 UTC ydbd size 8.4 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 70de92e merge: 7a23dbe diff diff %
ydbd size 9 038 139 360 Bytes 9 038 143 856 Bytes +4.4 KiB +0.000%
ydbd stripped size 489 037 768 Bytes 489 037 576 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 12:48:37 UTC Pre-commit check linux-x86_64-release-asan for 7a23dbe has started.
2024-09-18 12:48:48 UTC Artifacts will be uploaded here
2024-09-18 12:51:35 UTC ya make is running...
🔴 2024-09-18 14:36:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10365 10177 0 29 48 111

🟢 2024-09-18 14:37:35 UTC Build successful.
🟢 2024-09-18 14:38:11 UTC ydbd size 5.6 GiB changed* by -9.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 70de92e merge: 7a23dbe diff diff %
ydbd size 6 053 925 344 Bytes 6 053 915 664 Bytes -9.5 KiB -0.000%
ydbd stripped size 1 514 560 752 Bytes 1 514 555 504 Bytes -5.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:33:32 UTC Pre-commit check linux-x86_64-release-asan for 9130b18 has started.
2024-09-20 07:34:30 UTC Artifacts will be uploaded here
2024-09-20 07:38:14 UTC ya make is running...
🔴 2024-09-20 09:39:21 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10408 10000 0 73 285 50

🟢 2024-09-20 09:40:14 UTC Build successful.
🟢 2024-09-20 09:40:56 UTC ydbd size 5.6 GiB changed* by +25.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5a6abf merge: 9130b18 diff diff %
ydbd size 6 060 469 800 Bytes 6 060 495 408 Bytes +25.0 KiB +0.000%
ydbd stripped size 1 516 090 672 Bytes 1 516 105 200 Bytes +14.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:34:25 UTC Pre-commit check linux-x86_64-release-clang14 for 9130b18 has started.
2024-09-20 07:34:34 UTC Artifacts will be uploaded here
2024-09-20 07:37:21 UTC ya make is running...
🟢 2024-09-20 07:55:42 UTC Build successful.

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:34:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9130b18 has started.
2024-09-20 07:35:04 UTC Artifacts will be uploaded here
2024-09-20 07:37:53 UTC ya make is running...
🟡 2024-09-20 08:38:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14839 13361 0 2 1376 100

2024-09-20 08:40:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-20 08:51:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 14 0 0 0 92

🟢 2024-09-20 08:51:31 UTC Build successful.
🟢 2024-09-20 08:52:17 UTC ydbd size 8.4 GiB changed* by +82.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5a6abf merge: 9130b18 diff diff %
ydbd size 9 041 899 168 Bytes 9 041 983 328 Bytes +82.2 KiB +0.001%
ydbd stripped size 489 265 864 Bytes 489 278 472 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm merged commit f4914ce into ydb-platform:main Sep 27, 2024
10 of 12 checks passed
@fexolm fexolm deleted the fexolm/fix-partitioning5 branch September 27, 2024 08:48
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants