Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up register blob idx #9581

Merged
merged 7 commits into from
Sep 22, 2024
Merged

speed up register blob idx #9581

merged 7 commits into from
Sep 22, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:27:41 UTC Pre-commit check linux-x86_64-release-clang14 for 921c11a has started.
⚪ 2024-09-20 14:27:44 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:30:46 UTC ya make is running...
⚫ 2024-09-20 14:33:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:28:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 921c11a has started.
⚪ 2024-09-20 14:28:28 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:31:24 UTC ya make is running...
⚫ 2024-09-20 14:33:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:28:26 UTC Pre-commit check linux-x86_64-release-asan for 921c11a has started.
⚪ 2024-09-20 14:28:36 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:31:35 UTC ya make is running...
⚫ 2024-09-20 14:33:21 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:34:48 UTC Pre-commit check linux-x86_64-release-clang14 for c858f05 has started.
⚪ 2024-09-20 14:34:58 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:37:46 UTC ya make is running...
⚫ 2024-09-20 14:42:31 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:34:55 UTC Pre-commit check linux-x86_64-release-asan for c858f05 has started.
⚪ 2024-09-20 14:35:06 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:38:04 UTC ya make is running...
⚫ 2024-09-20 14:42:29 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:34:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for c858f05 has started.
⚪ 2024-09-20 14:35:06 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:38:01 UTC ya make is running...
⚫ 2024-09-20 14:42:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:44:11 UTC Pre-commit check linux-x86_64-release-clang14 for e46797f has started.
⚪ 2024-09-20 14:44:23 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:47:13 UTC ya make is running...
🟢 2024-09-20 14:54:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:44:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for e46797f has started.
⚪ 2024-09-20 14:45:33 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:48:52 UTC ya make is running...
⚫ 2024-09-20 15:29:15 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 14:46:46 UTC Pre-commit check linux-x86_64-release-asan for e46797f has started.
⚪ 2024-09-20 14:46:56 UTC Artifacts will be uploaded here
⚪ 2024-09-20 14:49:43 UTC ya make is running...
⚫ 2024-09-20 15:28:45 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 15:30:57 UTC Pre-commit check linux-x86_64-release-clang14 for 07a2f0b has started.
⚪ 2024-09-20 15:31:30 UTC Artifacts will be uploaded here
⚪ 2024-09-20 15:34:25 UTC ya make is running...
🟢 2024-09-20 15:42:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 15:33:04 UTC Pre-commit check linux-x86_64-release-asan for 07a2f0b has started.
⚪ 2024-09-20 15:33:18 UTC Artifacts will be uploaded here
⚪ 2024-09-20 15:36:14 UTC ya make is running...
🔴 2024-09-20 17:26:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10408 10044 0 48 270 46

🟢 2024-09-20 17:27:15 UTC Build successful.
🟢 2024-09-20 17:27:51 UTC ydbd size 5.6 GiB changed* by +86.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 06f4e89 merge: 07a2f0b diff diff %
ydbd size 6 062 009 600 Bytes 6 062 098 560 Bytes +86.9 KiB +0.001%
ydbd stripped size 1 516 450 160 Bytes 1 516 477 296 Bytes +26.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

⚪ 2024-09-20 15:33:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 07a2f0b has started.
⚪ 2024-09-20 15:33:48 UTC Artifacts will be uploaded here
⚪ 2024-09-20 15:36:44 UTC ya make is running...
🟡 2024-09-20 16:43:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14865 13147 0 12 1668 38

⚪ 2024-09-20 16:44:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-20 16:56:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
349 (only retried tests) 245 0 6 7 91

⚪ 2024-09-20 16:56:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-20 17:07:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 5 0 6 0 91

🟢 2024-09-20 17:07:36 UTC Build successful.
🟡 2024-09-20 17:08:20 UTC ydbd size 8.4 GiB changed* by +220.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 06f4e89 merge: 07a2f0b diff diff %
ydbd size 9 043 469 168 Bytes 9 043 694 752 Bytes +220.3 KiB +0.002%
ydbd stripped size 489 388 296 Bytes 489 396 296 Bytes +7.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

swalrus1
swalrus1 previously approved these changes Sep 20, 2024
View reviewed changes
@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 20, 2024 15:37
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner September 20, 2024 15:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 04:53:05 UTC Pre-commit check linux-x86_64-release-clang14 for 5b1970a has started.
⚪ 2024-09-21 04:53:14 UTC Artifacts will be uploaded here
⚪ 2024-09-21 04:56:05 UTC ya make is running...
🟢 2024-09-21 05:03:44 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 04:53:16 UTC Pre-commit check linux-x86_64-release-asan for 5b1970a has started.
⚪ 2024-09-21 04:53:25 UTC Artifacts will be uploaded here
⚪ 2024-09-21 04:56:26 UTC ya make is running...
🔴 2024-09-21 06:53:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10432 9993 0 77 305 57

🟢 2024-09-21 06:54:16 UTC Build successful.
🟢 2024-09-21 06:54:50 UTC ydbd size 5.6 GiB changed* by +87.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ec93b0 merge: 5b1970a diff diff %
ydbd size 6 063 001 616 Bytes 6 063 090 656 Bytes +87.0 KiB +0.001%
ydbd stripped size 1 516 681 744 Bytes 1 516 708 944 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 04:53:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5b1970a has started.
⚪ 2024-09-21 04:53:31 UTC Artifacts will be uploaded here
⚪ 2024-09-21 04:56:19 UTC ya make is running...
🟡 2024-09-21 05:59:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14858 13357 0 3 1383 115

🟡 2024-09-21 06:01:54 UTC ydbd size 8.4 GiB changed* by +220.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8ec93b0 merge: 5b1970a diff diff %
ydbd size 9 044 913 968 Bytes 9 045 139 992 Bytes +220.7 KiB +0.002%
ydbd stripped size 489 466 536 Bytes 489 474 536 Bytes +7.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Sep 21, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 07:16:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5b1970a has started.
⚪ 2024-09-21 07:17:35 UTC Artifacts will be uploaded here
⚪ 2024-09-21 07:20:58 UTC ya make is running...
🟡 2024-09-21 08:22:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14863 13383 0 7 1376 97

⚪ 2024-09-21 08:23:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-21 08:34:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 13 0 1 1 92

⚪ 2024-09-21 08:34:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-21 08:45:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 6 0 1 0 91

🟢 2024-09-21 08:45:52 UTC Build successful.
🟡 2024-09-21 08:46:31 UTC ydbd size 8.4 GiB changed* by +220.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8ec93b0 merge: 5b1970a diff diff %
ydbd size 9 044 913 968 Bytes 9 045 139 992 Bytes +220.7 KiB +0.002%
ydbd stripped size 489 466 536 Bytes 489 474 536 Bytes +7.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 07:17:44 UTC Pre-commit check linux-x86_64-release-clang14 for 5b1970a has started.
⚪ 2024-09-21 07:17:53 UTC Artifacts will be uploaded here
⚪ 2024-09-21 07:20:40 UTC ya make is running...
🟢 2024-09-21 07:26:40 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2024 •
edited
Loading

⚪ 2024-09-21 07:18:07 UTC Pre-commit check linux-x86_64-release-asan for 5b1970a has started.
⚪ 2024-09-21 07:18:18 UTC Artifacts will be uploaded here
⚪ 2024-09-21 07:21:14 UTC ya make is running...
🔴 2024-09-21 09:12:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10409 10204 0 44 48 113

🟢 2024-09-21 09:12:56 UTC Build successful.
🟢 2024-09-21 09:13:30 UTC ydbd size 5.6 GiB changed* by +87.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ec93b0 merge: 5b1970a diff diff %
ydbd size 6 063 001 616 Bytes 6 063 090 656 Bytes +87.0 KiB +0.001%
ydbd stripped size 1 516 681 744 Bytes 1 516 708 944 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 05:56:48 UTC Pre-commit check linux-x86_64-release-asan for 173f8eb has started.
⚪ 2024-09-22 05:56:58 UTC Artifacts will be uploaded here

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 05:56:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 173f8eb has started.
⚪ 2024-09-22 05:57:02 UTC Artifacts will be uploaded here

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:23:38 UTC Pre-commit check linux-x86_64-release-clang14 for 751df6b has started.
⚪ 2024-09-22 13:23:48 UTC Artifacts will be uploaded here
⚫ 2024-09-22 13:25:27 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:24:06 UTC Pre-commit check linux-x86_64-release-asan for 751df6b has started.
⚪ 2024-09-22 13:24:16 UTC Artifacts will be uploaded here
⚫ 2024-09-22 13:25:27 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:24:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 751df6b has started.
⚪ 2024-09-22 13:24:18 UTC Artifacts will be uploaded here
⚫ 2024-09-22 13:25:27 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:26:50 UTC Pre-commit check linux-x86_64-release-asan for 25d0429 has started.
⚪ 2024-09-22 13:26:54 UTC Artifacts will be uploaded here
⚪ 2024-09-22 13:29:41 UTC ya make is running...
🔴 2024-09-22 15:12:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10400 10215 0 32 45 108

🟢 2024-09-22 15:13:25 UTC ydbd size 5.6 GiB changed* by +86.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dbe09f9 merge: 25d0429 diff diff %
ydbd size 6 063 017 792 Bytes 6 063 106 760 Bytes +86.9 KiB +0.001%
ydbd stripped size 1 516 684 688 Bytes 1 516 711 824 Bytes +26.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:26:51 UTC Pre-commit check linux-x86_64-release-clang14 for 25d0429 has started.
⚪ 2024-09-22 13:26:54 UTC Artifacts will be uploaded here
⚪ 2024-09-22 13:29:40 UTC ya make is running...
🟢 2024-09-22 13:36:56 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

⚪ 2024-09-22 13:29:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 25d0429 has started.
⚪ 2024-09-22 13:29:28 UTC Artifacts will be uploaded here
⚪ 2024-09-22 13:32:24 UTC ya make is running...
🟡 2024-09-22 14:36:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14863 13374 0 1 1386 102

⚪ 2024-09-22 14:37:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-22 14:49:12 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 22 0 0 0 93

🟢 2024-09-22 14:49:19 UTC Build successful.
🟡 2024-09-22 14:49:55 UTC ydbd size 8.4 GiB changed* by +220.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dbe09f9 merge: 25d0429 diff diff %
ydbd size 9 044 940 832 Bytes 9 045 166 800 Bytes +220.7 KiB +0.002%
ydbd stripped size 489 467 560 Bytes 489 475 496 Bytes +7.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit b2b16e8 into ydb-platform:main Sep 22, 2024
8 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_register_blob_idx branch September 23, 2024 05:25
This was referenced Sep 23, 2024
Merged
Closed
@niksaveliev niksaveliev mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 3, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Oct 10, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
@ivanmorozov333 @zverevgeny
speed up register blob idx (ydb-platform#9581)
153cb7a
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @zverevgeny
speed up register blob idx (ydb-platform#9581)
b53bffa
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @zverevgeny
speed up register blob idx (ydb-platform#9581)
ec4793e
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
@ivanmorozov333 @zverevgeny
speed up register blob idx (ydb-platform#9581)
5dd06d8
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalrus1 swalrus1 swalrus1 approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanmorozov333 @swalrus1 @maximyurchuk