Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPortionInfo::GetRecordsCount speed up #9614

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 08:48:09 UTC Pre-commit check linux-x86_64-release-asan for cef2df9 has started.
2024-09-23 08:48:13 UTC Artifacts will be uploaded here
2024-09-23 08:51:01 UTC ya make is running...
🔴 2024-09-23 10:47:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10425 10167 0 65 71 122

🟢 2024-09-23 10:48:04 UTC Build successful.
🟢 2024-09-23 10:48:37 UTC ydbd size 5.6 GiB changed* by +560 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29fff7e merge: cef2df9 diff diff %
ydbd size 6 064 150 936 Bytes 6 064 151 496 Bytes +560 Bytes +0.000%
ydbd stripped size 1 516 845 488 Bytes 1 516 846 384 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 08:48:10 UTC Pre-commit check linux-x86_64-release-clang14 for cef2df9 has started.
2024-09-23 08:48:13 UTC Artifacts will be uploaded here
2024-09-23 08:51:09 UTC ya make is running...
🟢 2024-09-23 09:01:08 UTC Build successful.

Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 08:49:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for cef2df9 has started.
2024-09-23 08:49:09 UTC Artifacts will be uploaded here
2024-09-23 08:52:04 UTC ya make is running...
🟡 2024-09-23 09:56:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14865 13222 0 7 1603 33

2024-09-23 09:58:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 10:10:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
278 (only retried tests) 179 0 0 8 91

🟢 2024-09-23 10:10:16 UTC Build successful.
🟢 2024-09-23 10:11:42 UTC ydbd size 8.4 GiB changed* by -9.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 29fff7e merge: cef2df9 diff diff %
ydbd size 9 046 426 584 Bytes 9 046 416 784 Bytes -9.6 KiB -0.000%
ydbd stripped size 489 498 856 Bytes 489 498 792 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 23, 2024 14:36
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner September 23, 2024 14:36
@ivanmorozov333 ivanmorozov333 merged commit bacb7fa into ydb-platform:main Sep 23, 2024
11 of 13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_portion_records_count branch September 23, 2024 14:36
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Sep 24, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants