Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1294) Removed unnecessary collection HeadOf #1310

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

fanifieiev
Copy link
Contributor

This PR is for #1294

@0crat
Copy link
Collaborator

0crat commented Feb 21, 2020

This pull request #1310 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #1310 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
- Coverage     89.57%   89.56%   -0.02%     
+ Complexity     1671     1669       -2     
============================================
  Files           284      283       -1     
  Lines          4008     4004       -4     
  Branches        211      211              
============================================
- Hits           3590     3586       -4     
  Misses          385      385              
  Partials         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d437e49...d55ec65. Read the comment docs.

@victornoel
Copy link
Collaborator

@paulodamaso it's good to merge

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 24, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d55ec65 into yegor256:master Feb 24, 2020
@rultor
Copy link
Collaborator

rultor commented Feb 24, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 17min)

@0crat
Copy link
Collaborator

0crat commented Feb 24, 2020

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Feb 24, 2020
@0crat
Copy link
Collaborator

0crat commented Feb 24, 2020

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Feb 25, 2020

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Feb 25, 2020

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants