(#1292) SetOf and Sorted are real in memory sets #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
============================================
- Coverage 89.61% 89.57% -0.05%
+ Complexity 1665 1664 -1
============================================
Files 280 280
Lines 3987 3981 -6
Branches 211 211
============================================
- Hits 3573 3566 -7
Misses 380 380
- Partials 34 35 +1
Continue to review full report at Codecov.
|
|
This pull request #1316 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
victornoel
force-pushed
the
1292-setof-is-a-set
branch
from
c3e5d07 to
88ba4d9
Compare
fanifieiev
suggested changes
Mar 2, 2020
|
|
||
| /** | ||
| * Iterable as {@link Set}. | ||
| * | ||
| * <p>This class should be used very carefully. You must understand that |
There was a problem hiding this comment.
@victornoel Maybe just a few words describing this class???
Like: based on HashSet
There was a problem hiding this comment.
@fanifieiev thank you, it is done
|
|
||
| /** | ||
| * Sorted Iterable as {@link Set}. | ||
| * | ||
| * <p>This class should be used very carefully. You must understand that |
There was a problem hiding this comment.
@victornoel Maybe just a few words describing this class???
Like: based on TreeSet
There was a problem hiding this comment.
@fanifieiev thank you, it is done, I also added a todo so that the SortedSet interface is also implemented.
| @@ -58,15 +53,9 @@ public Sorted(final Comparator<T> cmp, final T... array) { | |||
| * @param cmp Comparator | |||
| * @param src An {@link Iterable} | |||
| */ | |||
| @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors") | |||
There was a problem hiding this comment.
@victornoel @paulodamaso We probably need to understand why this one required here, but not in ListOf
There was a problem hiding this comment.
@fanifieiev @paulodamaso what do you propose?
There was a problem hiding this comment.
@victornoel For example, create an issue for Qulice project
victornoel
force-pushed
the
1292-setof-is-a-set
branch
from
88ba4d9 to
971d218
Compare
fanifieiev
suggested changes
Mar 9, 2020
| @@ -58,15 +53,9 @@ public Sorted(final Comparator<T> cmp, final T... array) { | |||
| * @param cmp Comparator | |||
| * @param src An {@link Iterable} | |||
| */ | |||
| @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors") | |||
There was a problem hiding this comment.
@victornoel For example, create an issue for Qulice project
|
@victornoel ping |
|
@fanifieiev sorry for the delay. Please feel free to open such an issue in qulice, or maybe I can add a |
fanifieiev
approved these changes
Mar 14, 2020
There was a problem hiding this comment.
@victornoel Agree, will open a ticket in qulice project.
@paulodamaso please merge
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso @victornoel Oops, I failed. You can see the full log here (spent 9min) |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso @victornoel Oops, I failed. You can see the full log here (spent 6min) |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso @victornoel Oops, I failed. You can see the full log here (spent 5min) |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 13min) |
|
Code review was too long (14 days), architects (@paulodamaso) were penalized, see §55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1292.
I also did Sorted since it seemed a good idea and there wasn't much work.
I'm not clear why I had to ignore
PMD.ConstructorOnlyInitializesOrCallOtherConstructorsthough while it is not needed forListOforSetOf... !