1445 scalarof

[victornoel]

Some more changes for #1445. I took this opportunity to cleanup and improve test coverage

[victornoel]

@0crat refuse

[0crat]

@0crat refuse (here)

@victornoel The user @fabriciofx/z resigned from #1528, please stop working. Reason for job resignation: Order was cancelled

[0crat]

@victornoel/z everybody who has role REV is banned at #1528; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[victornoel]

@0crat assign @baudoliver7

[victornoel]

@baudoliver7 is it ok if I assign this to you? If not just say so and refuse it, if yes, I can add you as a REV to the project also if you are up for it :)

[0crat]

@0crat assign @baudoliver7 (here)

@victornoel This pull request #1528 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[baudoliver7]

@victornoel It's ok for me. You can add me as a REV to the project too, thx :)

[baudoliver7]

@victornoel Please, take a look.

[codecov-io]

Codecov Report

Merging #1528 (1cb1b88) into master (ecb0cf4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1528      +/-   ##
============================================
+ Coverage     90.79%   90.82%   +0.03%     
- Complexity     1555     1556       +1     
============================================
  Files           284      284              
  Lines          3670     3672       +2     
  Branches        125      125              
============================================
+ Hits           3332     3335       +3     
+ Misses          308      306       -2     
- Partials         30       31       +1     

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/proc/ForEach.java	100.00% <100.00%> (ø)	2.00 <0.00> (ø)
...c/main/java/org/cactoos/proc/ForEachInThreads.java	100.00% <100.00%> (ø)	2.00 <0.00> (ø)
...c/main/java/org/cactoos/proc/ForEachWithIndex.java	100.00% <100.00%> (ø)	2.00 <0.00> (ø)
src/main/java/org/cactoos/proc/ProcOf.java	100.00% <100.00%> (ø)	4.00 <2.00> (+1.00)
src/main/java/org/cactoos/scalar/And.java	100.00% <100.00%> (ø)	11.00 <3.00> (+1.00)
src/main/java/org/cactoos/scalar/AndInThreads.java	84.09% <100.00%> (ø)	16.00 <2.00> (ø)
src/main/java/org/cactoos/scalar/AndWithIndex.java	69.56% <100.00%> (+7.06%)	7.00 <1.00> (ø)
src/main/java/org/cactoos/scalar/Or.java	100.00% <100.00%> (ø)	12.00 <2.00> (ø)
src/main/java/org/cactoos/scalar/Solid.java	90.00% <0.00%> (-10.00%)	3.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/io/Zip.java	100.00% <0.00%> (ø)	4.00% <0.00%> (ø%)
... and 23 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb0cf4...1cb1b88. Read the comment docs.

[victornoel]

@baudoliver7 great, I will add you to cactoos as REV then, and thank you for the review, I answered them and marked those I fixed as resolved.

[baudoliver7]

@victornoel It's ok for me. Thank you for the training that you gave me :)

[victornoel]

@baudoliver7 thanks 👍

[victornoel]

@rultor merge

[rultor]

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

[0crat]

Job was finished in 16 hours, bonus for fast delivery is possible (see §36)

[0crat]

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@0crat quality good