Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1464 Add iterator.Paged and remove checkstyle suppression #1536

Merged

Conversation

baudoliver7
Copy link
Contributor

#1464

  • create iterator.Paged
  • refactor iterable.Paged
  • remove checkstyle suppression in iterable.Paged

@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #1536 (86ad37b) into master (1fed966) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1536   +/-   ##
=========================================
  Coverage     90.83%   90.83%           
- Complexity     1555     1558    +3     
=========================================
  Files           284      285    +1     
  Lines          3668     3668           
  Branches        125      123    -2     
=========================================
  Hits           3332     3332           
  Misses          306      306           
  Partials         30       30           
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/iterable/Paged.java 100.00% <ø> (+14.28%) 1.00 <0.00> (-1.00) ⬆️
src/main/java/org/cactoos/iterator/Paged.java 83.33% <83.33%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fed966...86ad37b. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jan 19, 2021

@victornoel/z everybody who has role REV is banned at #1536; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@baudoliver7
Copy link
Contributor Author

@victornoel PR done

src/main/java/org/cactoos/iterator/Paged.java Show resolved Hide resolved
src/main/java/org/cactoos/iterator/Paged.java Outdated Show resolved Hide resolved
src/main/java/org/cactoos/iterator/Paged.java Outdated Show resolved Hide resolved
src/main/java/org/cactoos/iterator/Paged.java Outdated Show resolved Hide resolved
@baudoliver7 baudoliver7 force-pushed the continue_refactoring_and_add_paged branch 2 times, most recently from 2894eba to 07be177 Compare January 20, 2021 13:50
@baudoliver7
Copy link
Contributor Author

@victornoel Some changes have been made

@baudoliver7 baudoliver7 force-pushed the continue_refactoring_and_add_paged branch from 07be177 to 85b9bb7 Compare January 23, 2021 11:35
@baudoliver7 baudoliver7 force-pushed the continue_refactoring_and_add_paged branch 5 times, most recently from 4477ddf to 26c58e3 Compare January 24, 2021 03:37
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2021

@victornoel/z everybody who has role REV is banned at #1536; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@baudoliver7 baudoliver7 force-pushed the continue_refactoring_and_add_paged branch from 26c58e3 to 86ad37b Compare January 24, 2021 08:38
@baudoliver7
Copy link
Contributor Author

@victornoel Some changes have been made.

@victornoel
Copy link
Collaborator

@baudoliver7 great, thx

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 25, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 86ad37b into yegor256:master Jan 25, 2021
@rultor
Copy link
Collaborator

rultor commented Jan 25, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@0crat 0crat removed the 0crat/scope label Jan 25, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 25, 2021

Job gh:yegor256/cactoos#1536 is not assigned, can't get performer

@baudoliver7 baudoliver7 deleted the continue_refactoring_and_add_paged branch January 25, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants