Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1526) For consistency sake with func #1539

Merged
merged 4 commits into from
Jan 31, 2021

Conversation

baudoliver7
Copy link
Contributor

@baudoliver7 baudoliver7 commented Jan 27, 2021

#1526

  • Introduce envelope for Proc, BiFunc, Callable and Runnable
  • simplify the code of ProcOf and BiFuncOf etc by extending their envelope

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2021

@victornoel/z everybody who has role REV is banned at #1539; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@baudoliver7
Copy link
Contributor Author

@victornoel I submitted a PR but it seems reviewer is missing

@victornoel
Copy link
Collaborator

@baudoliver7 I'm receiving the same notifications as you FYI so I'm aware of it :)

I will take a look at it when I have some free time :)

@baudoliver7
Copy link
Contributor Author

@victornoel Good :)

Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 some comments :)

src/main/java/org/cactoos/proc/ProcEnvelope.java Outdated Show resolved Hide resolved
src/main/java/org/cactoos/package-info.java Show resolved Hide resolved
@baudoliver7 baudoliver7 force-pushed the for_consistency_sake_with_func branch from aa50c09 to 49ead45 Compare January 30, 2021 11:21
@baudoliver7
Copy link
Contributor Author

@victornoel Some changes have been made

@victornoel
Copy link
Collaborator

@baudoliver7 great, thx

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 31, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2eef5c9 into yegor256:master Jan 31, 2021
@rultor
Copy link
Collaborator

rultor commented Jan 31, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 15min)

@baudoliver7 baudoliver7 deleted the for_consistency_sake_with_func branch January 31, 2021 18:54
@0crat
Copy link
Collaborator

0crat commented Jan 31, 2021

Job gh:yegor256/cactoos#1539 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants