-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1526) For consistency sake with func #1539
(#1526) For consistency sake with func #1539
Conversation
@victornoel I submitted a PR but it seems reviewer is missing |
@baudoliver7 I'm receiving the same notifications as you FYI so I'm aware of it :) I will take a look at it when I have some free time :) |
@victornoel Good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 some comments :)
aa50c09
to
49ead45
Compare
@victornoel Some changes have been made |
@baudoliver7 great, thx |
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 15min) |
Job |
#1526