-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the purpose of enforcing the use of the @since tag? #1036
Comments
@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot! |
@krzyk any opinion on this? |
@krzyk ping |
@victornoel personally I like this system:
|
@llorllale this is a good enough system (even though I'm not clear how I can be able to know, when introducing a class, if the next release is going to be a feature one or a bug fix one), but it does not answer the fundamental question IMHO: what purpose does it have to specify this |
The only practical utility I find is when you have to determine the minimum compatible version of a library that is referenced by several others (dependency hell). This seldom happens based on my experience |
@victornoel @llorllale I think @yegor256 Are you OK with dropping |
@krzyk I could go either way with the removal of
What do you mean? |
@llorllale I mean if given library wants to enforce |
@krzyk qulice should support custom extensions (in addition to the checks already built in) so that projects that want to enforce |
@krzyk well, I find this tag useful. It indicates the minimum version where this feature is available. I would leave it in the list of required tags. |
@yegor256 what you say is already provided by git, why do we need to have it in the code itself? It's trying to do manually (and often badly because it requires a lot of effort to have correct information, just look at cactoos codebase, it's a mess, the since tags are useless in there) what a versioning system does without fail. Also, I just don't get why people wants to know that information: usually, when you want to have a method from a lib, you just take the last version and you know you will have it, nobody is going to think "I need this new method, I will take this old version of cactoos full of bugs that were corrected in newer version". |
@victornoel these |
The
@since
tag is enforced by qulice to be used on public elements of a Java API.I wonder what is the need for it? What does it provide?
We removed in the past the need for the
@author
tag because it was already covered by version control. The@since
tag does not seem to provide anything more than what version control is providing.But maybe I am missing something. Is there some rationale for it?
If there are none, I propose to remove this rule from qulice.
@yegor256 @krzyk
The text was updated successfully, but these errors were encountered: