(#203) Improve TextMatcher API and messages #228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=========================================
Coverage 98.82% 98.82%
Complexity 139 139
=========================================
Files 27 27
Lines 339 339
Branches 5 4 -1
=========================================
Hits 335 335
Misses 4 4
Continue to review full report at Codecov.
|
victornoel
force-pushed
the
text-matcher
branch
from
65655bc to
f35165c
Compare
victornoel
force-pushed
the
text-matcher
branch
from
f35165c to
ae8c090
Compare
| * @param expected The description of the matcher's expected text. | ||
| * @param expected The prefix of the matcher's expected text. | ||
| * @param actual The prefix of the actual text. | ||
| * @checkstyle ParameterNumberCheck (2 lines) | ||
| */ | ||
| public TextMatcher( |
There was a problem hiding this comment.
@victornoel Could you add a version tag for this new constructor ?
There was a problem hiding this comment.
@baudoliver7 in cactoos-matchers we only use @since 1.0.0 everywhere on classes and not on methods. Once v1 will be released, we will start doing it properly. I think actually we should do the same in cactoos maybe... Personally I find those @since tags really useless, see yegor256/qulice#1036
|
@victornoel thx, looks good for me. |
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 9min) |
|
Job was finished in 22 hours, bonus for fast delivery is possible (see §36) |
|
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality acceptable |
|
@baudoliver7 please make sure you will find at least 3 issues during next CR, thanks! |
This is in the continuation of #203 to improve the API of TextMatcher and its messages