Private repos should not be shown if logged in user can't access them

[carlosmiranda]

This is what the homepage looks like, when I'm logged in:

The first two links of "recent conversations" are to repos that are private, namely teamed/sigzig and teamed/xockets-layer.

When I log out, they're still visible:

Links to private repos should not be shown if a user is not logged in, or is not granted privileges to view that repo.

[alex-palevsky]

I'll ask someone to take care of this task soon

[alex-palevsky]

@carlosmiranda many thanks for the bug report, I added 15 mins to your acc, transaction 51640283

[alex-palevsky]

@nhekfqn this is your ticket,please proceed

[alex-palevsky]

@carlosmiranda there is no milestone yet, so I set it to 0.3

[alex-palevsky]

@skirpichenok This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here; The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

[skirpichenok]

@alex-palevsky should I run it locally to fix it or should I fix it using the tests?

[alex-palevsky]

@alex-palevsky should I run it locally to fix it or should I fix it using the tests?

@skirpichenok I can't help you with technical questions. address them to the author of the ticket or project architect (@yegor256)

[skirpichenok]

@yegor256, @carlosmiranda should I run it locally to fix it or should I fix it using the tests only?

[yegor256]

@skirpichenok no need to run anything (it's a bad practice). each bug should first be reproduced in a unit/integration test and then fixed. "running locally" is debugging, which is a bad practice.

[skirpichenok]

@yegor256 I guess that you are talking about TDD. correct?

[skirpichenok]

@carlosmiranda, @yegor256 This takes much more than 30 mins....

I've found this method in the TkHome:

private Directives recent() throws IOException {
    final Directives dirs = new Directives().add("recent");
    final PrettyTime pretty = new PrettyTime();
    for (final Talk talk : Iterables.limit(this.talks.recent(), Tv.FIVE)) {
        dirs.add("talk").set(talk.name())
            .attr("timeago", pretty.format(talk.updated()));
        final XML xml = talk.read();
        if (!xml.nodes("/talk/wire/href").isEmpty()) {
            dirs.attr(
                "href",
                talk.read().xpath("/talk/wire/href/text()").get(0)
            );
        }
        dirs.up();
    }
    return dirs;
}

but how can I access github here to check that a repo is private? Or should I chose another way to check it? Can you suggest something?

[alex-palevsky]

@skirpichenok you're working with this ticket for the last 15 days. If it is not closed within the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck; -30 added to your rating, current score is: -30

[skirpichenok]

@alex-palevsky I closed my conract. Try to find somebody else.

[alex-palevsky]

@alex-palevsky I closed my conract. Try to find somebody else.

@skirpichenok 30 points was deducted from your rating

[alex-palevsky]

@alex-palevsky I closed my conract. Try to find somebody else.

@skirpichenok right, I will find someone else, no problem

[original-brownbear]

@alex-palevsky assign me please.

[alex-palevsky]

@alex-palevsky assign me please.

@original-brownbear there are already 8 active tasks in the project, we can't have more

[original-brownbear]

@alex-palevsky this is postponed.

[alex-palevsky]

@alex-palevsky this is postponed.

@original-brownbear right, I added "postponed" label

[alex-palevsky]

@alex-palevsky this is postponed.

@original-brownbear right, I'll try to find someone else for this task

[Glusk]

@yegor256
Was this resolved with #1320? If so, perhaps this issue should be closed as well.