1.58 #1013

alex-palevsky · 2016-02-21T17:52:10Z

Please, publish a new release 1.58 (or higher). Don't forget to update us here regularly (at least once a week), as explained in this article.

alex-palevsky · 2016-02-22T13:22:07Z

@original-brownbear milestone set to 2.0 (correct me if I am wrong)

original-brownbear · 2016-02-22T15:59:45Z

@yegor256 before writing up the report here, anything you'd like to see handled with priority?

yegor256 · 2016-02-22T22:55:20Z

@original-brownbear nope, I don't have any priorities. maybe that problem with col is rather annoying (I see it in logs every day): #884 all the rest is not urgent

original-brownbear · 2016-02-23T04:01:47Z

@yegor256 @alex-palevsky given that the last release was 1.57 on Aug 23, 2015 and the latest
pre-release is 1.61.3 already:
I would go for 1.62 here, closing #884, #982, #960 and #901, in order to get back to release discipline asap.

Report

I will provide scope status in a few hours, I thought the below should be reported asap though.
Especially risk 1. (given it introduces risk into all other projects!) I think you should be aware of rather sooner than later.

Issues

Developers fail tasks, (2016: 10 closed PRs, 5 by me, 2 related to readme, 3 close w/o merge, but many tickets time-out->reassigned )
Unstable Docker interaction due to ssh/bash/cli implementation of this
(Integration) tests are by far not comprehensive enough
Instabilities in Interaction with Git

Risks

Using the default image (having a non-deterministic build) is widespread in other projects, adjusting Rultor dependencies may cause widespread problems similar to those ~1 week ago Deprecate Using the yegor256/rultor Docker Image for Other Projects #1018 [4,8]
We may fail to find developers capable to contribute to current open issues productively [9,6]
Tests are not safe enough[7,4]
Piping user supplied input to the Docker host's root shell may be exploitable[3,8]

yegor256 · 2016-02-23T05:16:53Z

@original-brownbear looks perfect, many thanks!

alex-palevsky · 2016-02-23T17:23:39Z

@original-brownbear could you please pick this up? This article explains how we work. Any technical questions you may ask right here

The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

original-brownbear · 2016-02-23T17:25:07Z

@alex-palevsky on it already :)

original-brownbear · 2016-02-24T21:42:46Z

@rultor release tag is 1.61.4

rultor · 2016-02-24T21:43:57Z

@rultor release tag is 1.61.4

@original-brownbear OK, I will release it now. Please check the progress here

rultor · 2016-02-24T21:55:12Z

@rultor release tag is 1.61.4

@alex-palevsky @original-brownbear Oops, I failed. You can see the full log here (spent 11min)

remote:        Downloading: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/xmlgraphics-commons/2.1/xmlgraphics-commons-2.1.jar        
remote:        Downloaded: http://repo.maven.apache.org/maven2/com/jcabi/jcabi-github/0.26/jcabi-github-0.26.jar (1621 KB at 25323.8 KB/sec)        
remote:        Downloaded: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/xmlgraphics-commons/2.1/xmlgraphics-commons-2.1.jar (630 KB at 15747.6 KB/sec)        
remote:        Downloaded: http://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-kms/1.10.51/aws-java-sdk-kms-1.10.51.jar (342 KB at 461.2 KB/sec)        
remote:        Downloaded: http://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-s3/1.10.51/aws-java-sdk-s3-1.10.51.jar (595 KB at 704.7 KB/sec)        
remote:        Downloaded: http://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-core/1.10.51/aws-java-sdk-core-1.10.51.jar (573 KB at 514.8 KB/sec)        
remote:        [INFO]         
remote:        [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ rultor ---        
remote:        [INFO]         
remote:        [INFO] --- maven-dependency-plugin:2.8:list (default-cli) @ rultor ---        
remote:        [INFO]         
remote:        [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-java) @ rultor ---        
remote:        [INFO]         
remote:        [INFO] --- buildnumber-maven-plugin:1.3:create (jcabi-build-number) @ rultor ---        
remote:        [INFO] ShortRevision tag detected. The value is '7'.        
remote:        [INFO] Executing: /bin/sh -c cd /tmp/build_0e71b69344b3f4481601edc1d6dd04a5 && git rev-parse --verify --short=7 HEAD        
remote:        [INFO] Working directory: /tmp/build_0e71b69344b3f4481601edc1d6dd04a5        
remote:        [INFO] Storing buildNumber: null at timestamp: 2016-02-24T21:54:44        
remote:        [WARNING] Cannot get the branch information from the git repository:         
remote:        Detecting the current branch failed: fatal: Not a git repository (or any parent up to mount point /tmp)        
remote:        Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).        
remote:                
remote:        [INFO] ShortRevision tag detected. The value is '7'.        
remote:        [INFO] Executing: /bin/sh -c cd /tmp/build_0e71b69344b3f4481601edc1d6dd04a5 && git rev-parse --verify --short=7 HEAD        
remote:        [INFO] Working directory: /tmp/build_0e71b69344b3f4481601edc1d6dd04a5        
remote:        [INFO] Storing buildScmBranch: UNKNOWN_BRANCH        
remote:        [INFO]         
remote:        [INFO] --- buildnumber-maven-plugin:1.3:create-timestamp (jcabi-build-number) @ rultor ---        
remote:        [INFO] ------------------------------------------------------------------------        
remote:        [INFO] BUILD FAILURE        
remote:        [INFO] ------------------------------------------------------------------------        
remote:        [INFO] Total time: 11.532s        
remote:        [INFO] Finished at: Wed Feb 24 21:54:44 UTC 2016        
remote:        [INFO] Final Memory: 26M/289M        
remote:        [INFO] ------------------------------------------------------------------------        
remote:        [ERROR] Failed to execute goal nl.geodienstencentrum.maven:sass-maven-plugin:2.15:update-stylesheets (generate-css) on project rultor: The plugin nl.geodienstencentrum.maven:sass-maven-plugin:2.15 requires Maven version 3.2.5 -> [Help 1]        
remote:        [ERROR]         
remote:        [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.        
remote:        [ERROR] Re-run Maven using the -X switch to enable full debug logging.        
remote:        [ERROR]         
remote:        [ERROR] For more information about the errors and possible solutions, please read the following articles:        
remote:        [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginIncompatibleException        
remote: 
remote:  !     ERROR: Failed to build app with Maven        
remote:        We're sorry this build is failing! If you can't find the issue in application code,        
remote:        please submit a ticket so we can help: https://help.heroku.com/        
remote: 
remote: 
remote:  !     Push rejected, failed to compile Java app        
remote: 
remote: Verifying deploy...        
remote: 
remote: !   Push rejected to rultor.        
remote: 
To [email protected]:rultor.git
 ! [remote rejected] __rultor -> master (pre-receive hook declined)
error: failed to push some refs to '[email protected]:rultor.git'
container febc8ce5ca600477902154b6d682de5c8d4057cb0ba48576c62c570c62597f6e is dead
Wed Feb 24 21:55:08 UTC 2016

original-brownbear · 2016-02-24T22:24:49Z

@rultor release tag is 1.61.4

rultor · 2016-02-24T22:27:07Z

@rultor release tag is 1.61.4

@original-brownbear OK, I will release it now. Please check the progress here

rultor · 2016-02-24T23:26:21Z

@rultor release tag is 1.61.4

@original-brownbear Done! FYI, the full log is here (took me 59min)

alex-palevsky · 2016-02-25T16:43:47Z

@alex-palevsky on it already :)

@original-brownbear thanks

original-brownbear · 2016-02-27T11:30:37Z

@alex-palevsky I need your help here :) , the only thing open and without a proper PR is #960 requiring action on your end.

original-brownbear · 2016-02-28T12:34:24Z

@alex-palevsky another thing:

We need to move the milestone 2.0. It has been overdue for months now. Extrapolating from the number of tickets being resolved lately and the number of open tickets, I suggest to move it 2 months into the future starting from today.

original-brownbear · 2016-02-29T01:41:59Z

@yegor256 @alex-palevsky
Release 1.62:

~~col: Invalid or incomplete multibyte or wide character #884 closed and released~~
~~rultor rejects deploy command #982 closed and released~~
check for release versions that are lower than already existing ones #960 PR waiting for CR
~~Command/Output Ordering is messed up nondeterministically #901 closed and released~~

Issues

Missing documentation Deprecate Using the yegor256/rultor Docker Image for Other Projects #1018 is starting to cause first issues Rultor Build Fails on Recent Versions of yegor256/rultor jcabi/jcabi-aether#82, see risk 1. Will be addressed asap.
Developers fail tasks
Unstable Docker interaction due to ssh/bash/cli implementation of this, update: Fixes here in above tickets improving I/O, still image/volume handling causes trouble
(Integration) tests are by far not comprehensive enough
Instabilities in Interaction with Git

Risks

Using the default image (having a non-deterministic build) is widespread in other projects, adjusting Rultor dependencies may cause widespread problems similar to those ~1 week ago Deprecate Using the yegor256/rultor Docker Image for Other Projects #1018 [6,8] update: See issue 3, more likely to hit projects then expected.
We may fail to find developers capable to contribute to current open issues productively [9,6]
Tests are not safe enough[5,4] update: improvements around authentication, chat interaction

~~4. Piping user supplied input to the Docker host's root shell may be exploitable[3,8]~~ update:solved by releasing --privileged flag removal fix and line buffering Docker I/O

yegor256 · 2016-02-29T16:48:37Z

@original-brownbear thanks for the update!

alex-palevsky · 2016-02-29T19:36:10Z

@original-brownbear there are a few issues by par.33:

some tasks are stuck: Mails.java:54-56: Describe in file 2014-07-13-reference.md config... #828 (326 days), MailsTest.java:95-96: Implement method sendsToRecipients. It must... #829 (326 days), Mails.java:47-53: Implement Mails agent. Similar to... #830 (325 days), ReleaseBinaries.java:47-49: Implement attaching artifacts to release,... #832 (325 days), Private repos should not be shown if logged in user can't access them #773 (381 days), architect per command #806 (339 days), master is used instead of default repo branch #818 (333 days), Rultor "stop" command issues wrong/confusing messages #864 (259 days); please resolve this. You have three options: 1) mark some of them as "postponed", 2) re-assign them, or 3) help performers to resolve them.
some issues were reported some time ago, but still not dispatched: Clarify Plans For EC2 Tickets Given ECS GA #1021, RFE: Add rebase command #876, give Docker a storage quota of 20Gb #669. Please, do something about them. Either register as bugs or ask their reporters to close them.
there are some milestones with missed dates: 2.0. Please, do something about it.

added -25 to your rating, now it is equal to +459

original-brownbear · 2016-02-29T20:02:02Z

@alex-palevsky sorry, I feel the need to defend myself here :)

there are some milestones with missed dates: 2.0. Please, do something about it.

I asked you to move the milestone #1013 (comment), I think this is the best I can do given that the milestone was already missed when I started as an architect here.

Not dispatched issues:
#669 asked to close this, now it may turn out this is still a valid issue but either way I think I properly reacted here in terms of following the rules :)
#876 Asked the author to close this also asked to tag this as invalid.
#1021 Asked to have this assigned to @yegor256 and created it myself, was this not a valid way of dispatching the issue?

About the stuck tasks:
This was already mentioned here: yegor256/qulice#686 (comment) and 2 comments below that said to be fixed. As pointed out there, it is essentially impossible to to do anything but postponing indefinitely with stuck tasks you "inherit".

Not a big deal either way :), just asking how I could have addressed things better here?

original-brownbear · 2016-03-04T11:41:42Z

@rultor release tag is 1.61.8

rultor · 2016-03-04T11:42:03Z

@rultor release tag is 1.61.8

@original-brownbear OK, I will release it now. Please check the progress here

rultor · 2016-03-04T11:49:18Z

@rultor release tag is 1.61.8

@alex-palevsky @original-brownbear Oops, I failed. You can see the full log here (spent 7min)

[INFO] 
[INFO] Starting JavaScript task:
[INFO] 
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ rultor ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 131 source files to /home/r/repo/target/classes
[INFO] 
[INFO] --- exec-maven-plugin:1.4.0:exec (Copyright check) @ rultor ---
./settings.xml
Files above must have copyright block in header
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.430 s
[INFO] Finished at: 2016-03-04T11:48:03+00:00
[INFO] Final Memory: 58M/430M
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "rultor" could not be activated because it does not exist.
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (Copyright check) on project rultor: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (Copyright check) on project rultor: Command execution failed.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed.
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:276)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
    ... 20 more
Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
    at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
    at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:660)
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:265)
    ... 22 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container c48b8248bf4c93110b7022e6a7120a428d8342dee37a3f58260c5c9065962377 is dead
Fri Mar  4 11:49:11 UTC 2016

original-brownbear · 2016-03-04T12:21:10Z

@rultor release tag is 1.61.8

rultor · 2016-03-04T12:21:49Z

@rultor release tag is 1.61.8

@original-brownbear OK, I will release it now. Please check the progress here

rultor · 2016-03-04T13:15:21Z

@rultor release tag is 1.61.8

@original-brownbear Done! FYI, the full log is here (took me 53min)

original-brownbear · 2016-03-04T17:58:26Z

@yegor256 Release 1.61.8 contains all agreed upon issue's fixed and the issues are closed.
I think we're done here right ?

yegor256 · 2016-03-05T06:18:35Z

@original-brownbear yes, we're good

yegor256 · 2016-03-05T06:18:45Z

@alex-palevsky mark release 1.61.8 as final

alex-palevsky · 2016-03-06T12:18:36Z

@alex-palevsky mark release 1.61.8 as final

@yegor256 right, release 1.61.8 is set to "final"

alex-palevsky · 2016-03-06T12:25:15Z

@original-brownbear please, pay attention to this (par.33):

some tasks are stuck: Mails.java:47-53: Implement Mails agent. Similar to... #830 (330 days), Private repos should not be shown if logged in user can't access them #773 (385 days), architect per command #806 (343 days), master is used instead of default repo branch #818 (337 days), Rultor "stop" command issues wrong/confusing messages #864 (263 days), RFE: GitHub: Refuse merge on "failed" build status #869 (261 days), rultor merge failed: "no space left on device" #906 (225 days); please resolve this. You have three options: 1) mark some of them as "postponed", 2) re-assign them, or 3) help performers to resolve them.
these issues are still not dispatched anyhow: Clarify Plans For EC2 Tickets Given ECS GA #1021, RFE: Add rebase command #876. Either register as bugs or ask their reporters to close.
some milestones are due: 2.0. Please, either close them or update due dates.

-25 added to your rating, at the moment it is: +619

original-brownbear · 2016-03-06T12:39:47Z

@alex-palevsky please move milestone 2.0 to April 28th.

alex-palevsky · 2016-03-06T14:01:53Z

@alex-palevsky please move milestone 2.0 to April 28th.

@original-brownbear sure, milestone set to 2.0

original-brownbear · 2016-03-06T17:12:29Z

@alex-palevsky please close this, it's still open in my agenda :)

alex-palevsky · 2016-03-06T18:47:08Z

@alex-palevsky please close this, it's still open in my agenda :)

@original-brownbear I will close it when there is a new release published

original-brownbear · 2016-03-06T18:56:45Z

@alex-palevsky Sorry I don't understand 1.61.8 was marked as final and I already have #1043 open for the next release.
What action do I need to take here?

alex-palevsky · 2016-03-07T15:23:52Z

@original-brownbear Closing..

alex-palevsky · 2016-03-07T15:26:32Z

@original-brownbear 31 mins was added to your account, many thanks for your contribution (payment AP-33L476332W905053B)! The task took 284 hours and 43 mins.. here is how the bonus is calculated: t=4604, c=228, h=3833, diff=1.57..master. +31 added to your rating, at the moment it is: +903

alex-palevsky added ARC labels Feb 21, 2016

alex-palevsky added this to the 2.0 milestone Feb 22, 2016

alex-palevsky added the @original-brownbear label Feb 23, 2016

alex-palevsky closed this as completed Mar 7, 2016

1.58 #1013

1.58 #1013

Comments

alex-palevsky commented Feb 21, 2016

alex-palevsky commented Feb 22, 2016

original-brownbear commented Feb 22, 2016

yegor256 commented Feb 22, 2016

original-brownbear commented Feb 23, 2016

Report

Issues

Risks

yegor256 commented Feb 23, 2016

alex-palevsky commented Feb 23, 2016

original-brownbear commented Feb 23, 2016

original-brownbear commented Feb 24, 2016

rultor commented Feb 24, 2016

rultor commented Feb 24, 2016

original-brownbear commented Feb 24, 2016

rultor commented Feb 24, 2016

rultor commented Feb 24, 2016

alex-palevsky commented Feb 25, 2016

original-brownbear commented Feb 27, 2016

original-brownbear commented Feb 28, 2016

original-brownbear commented Feb 29, 2016

Issues

Risks

yegor256 commented Feb 29, 2016

alex-palevsky commented Feb 29, 2016

original-brownbear commented Feb 29, 2016

original-brownbear commented Mar 4, 2016

rultor commented Mar 4, 2016

rultor commented Mar 4, 2016

original-brownbear commented Mar 4, 2016

rultor commented Mar 4, 2016

rultor commented Mar 4, 2016

original-brownbear commented Mar 4, 2016

yegor256 commented Mar 5, 2016

yegor256 commented Mar 5, 2016

alex-palevsky commented Mar 6, 2016

alex-palevsky commented Mar 6, 2016

original-brownbear commented Mar 6, 2016

alex-palevsky commented Mar 6, 2016

original-brownbear commented Mar 6, 2016

alex-palevsky commented Mar 6, 2016

original-brownbear commented Mar 6, 2016

alex-palevsky commented Mar 7, 2016

alex-palevsky commented Mar 7, 2016