Fixing: Deprecate Using the yegor256/rultor Docker Image #1045

sebing · 2016-03-07T14:24:35Z

The start and end bash scripts are modified to accommodate the changes.

Fixing(#1018)

alex-palevsky · 2016-03-07T15:19:47Z

@sebing I will find a reviewer for your pull requests shortly, thanks for contribution!

original-brownbear · 2016-03-07T15:23:01Z

@sebing seems this does not pass tests :(, while a reviewer is looked, for can you fix that ? :)

alex-palevsky · 2016-03-07T15:26:32Z

@mkordas review this pull request please

mkordas · 2016-03-07T15:42:59Z

@sebing I'm on it

mkordas · 2016-03-07T15:45:18Z

src/main/resources/com/rultor/agents/daemons/end.sh

@@ -1,4 +1,9 @@
 #!/usr/bin/env bash
+#@todo #754:30min Remove the deprecation code from the shell.
+# Move the code to Java. May be


@sebing what stops you from moving it to Java in this PR?

@mkordas May be the lack of my understanding of the project :)

in the class com.rultor.agents.daemons.EndsDaemon and com.rultor.agents.daemons.StartsDaemon I need the image. I cannot find the flow.

@original-brownbear can you propose some design solution here?

@sebing @mkordas I don't think a design solution is even needed here fortunately :)
Look @sebing , just give this file a glance https://github.com/yegor256/rultor/blob/master/src/test/java/com/rultor/profiles/GithubProfileITCase.java.
It clearly shows how to extract the script section from the Profile, this should give you all you need to figure out the image on the Java end, shouldn't it ? :)

@original-brownbear Now the next question :) Sorry for keep asking them. (May be the link give the guts to ask them.

I can create a profile image like the test you have given, and equate that. But how do I get the current profile?

How do i get the current Profile in com.rultor.agents.daemons.EndsDaemon?

@sebing why not just go by the xpath on the xml that is available in com.rultor.agents.daemons.EndsDaemon, no need for instantiating a Profile,
just work by analogy from the Profile logic and how it interprets the XML, other examples of how this looks are all over the codebase :)

mkordas · 2016-03-07T15:55:44Z

@sebing see my review above

mkordas · 2016-03-07T18:13:03Z

@sebing are these test failures related?

  StartsRequestTest.runsAsRootIfRequested:357->exec:386 Â» IllegalArgument Non-ze...
  StartsRequestTest.startsDeployRequest:138->exec:386 Â» IllegalArgument Non-zero...
  StartsRequestTest.startsMergeRequest:229->exec:386 Â» IllegalArgument Non-zero ...
  StartsRequestTest.startsReleaseRequest:196->exec:386 Â» IllegalArgument Non-zer...

mkordas · 2016-03-08T12:23:48Z

@sebing will you work on this today?

sebing · 2016-03-08T12:27:17Z

@mkordas I am trying to convert the code into java. But I have difficulty in doing so.
I have difficulty in understanding the basic stuffs, What is an image? :)

sebing · 2016-03-08T18:48:33Z

@mkordas I have pushed the changes, I have not tested them as I have not in a linux machine. I will do that tomorrow. Please let me know your thoughts.

mkordas · 2016-03-08T21:14:29Z

src/main/java/com/rultor/agents/daemons/StartsDaemon.java

            .xpath("/talk/daemon[not(started)]")
-            .strict(1)
+            .strict(1);
+        final XML node = xml.node("/p/entry[@key='assets']/entry");


@sebing this line doesn't compile

mkordas · 2016-03-10T20:45:56Z

@original-brownbear any idea why PR is urgent and postponed at the same time?

mkordas · 2016-03-10T20:49:30Z

@alex-palevsky why this PR has both urgent and postponed labels?

original-brownbear · 2016-03-10T20:50:36Z

@mkordas no idea how postponed got added, only urgent is correct. Let's see what @alex-palevsky has to say :)

mkordas · 2016-03-10T20:51:04Z

@sebing OK, I think it is good enough, you've really put a lot of effort into this PR

mkordas · 2016-03-10T20:51:08Z

@rultor merge

rultor · 2016-03-10T20:52:14Z

@rultor merge

@mkordas Thanks for your request. @original-brownbear Please confirm this.

original-brownbear · 2016-03-10T21:09:34Z

src/test/java/com/rultor/agents/daemons/EndsDaemonITCase.java

+        for (final String path
+            : talk.read().xpath("/p/entry[@key='merge']/entry[@key='script']")
+        ) {
+            if ("yegor256/rultor".equals(path)) {


@sebing We need this to not fire when the repo is the actual Rultor repo: https://github.com/yegor256/rultor :)

@original-brownbear Sorry to ask again ;)
How do I get repo of the current run? Is that information available in the xml or somehow I have to create com.jcabi.github.Repo?

@sebing puzzle is fine too ;) really you did a lot here already!

@original-brownbear I have added a puzzle. But for my curiosity, how do I know the repo?

original-brownbear · 2016-03-10T21:11:52Z

@sebing just one really trivial comment, can you add a condition for the actual Rultor repo please ?:)
Rest looks really nice! Thanks guys!

sebing · 2016-03-11T10:11:57Z

@mkordas I added a puzzle, can you review them.

mkordas · 2016-03-11T12:05:10Z

@sebing looks good!

mkordas · 2016-03-11T12:05:15Z

@rultor merge

rultor · 2016-03-11T12:05:24Z

@rultor merge

@mkordas Thanks for your request. @original-brownbear Please confirm this.

original-brownbear · 2016-03-11T14:03:20Z

@rultor merge :)

rultor · 2016-03-11T14:04:21Z

@rultor merge :)

@original-brownbear OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-03-11T14:17:56Z

@rultor merge :)

@original-brownbear Done! FYI, the full log is here (took me 14min)

mkordas · 2016-03-11T15:27:41Z

@sebing merged, please close PR

sebing · 2016-03-11T15:29:48Z

@mkordas merged the code, so closing the PR. Thanks for your help.

mkordas · 2016-03-11T17:15:14Z

@sebing thank you too!

mkordas · 2016-03-11T17:15:20Z

@rultor deploy

rultor · 2016-03-11T17:15:50Z

@rultor deploy

@mkordas Thanks for your request. @original-brownbear Please confirm this.

original-brownbear · 2016-03-11T17:16:58Z

@rultor deploy.

rultor · 2016-03-11T17:17:57Z

@rultor deploy.

@original-brownbear OK, I'll try to deploy now. You can check the progress here

rultor · 2016-03-11T17:22:49Z

@rultor deploy.

@original-brownbear Done! FYI, the full log is here (took me 5min)

alex-palevsky · 2016-03-13T12:14:40Z

@mkordas quality is good here, 10 mins added to @original-brownbear (our architect) in transaction AP-3CA966592B191914W... Much obliged! I have added 1 hour and 25 mins to your account in payment "56e55953d1862d29ab000223", 97 hours and 22 mins spent... review comments (c=70) added as a bonus... +85 to your rating, your total score is +8798

Fixing the issue 1018

a755cad

sebing mentioned this pull request Mar 7, 2016

Deprecate Using the yegor256/rultor Docker Image for Other Projects #1018

Closed

alex-palevsky added CR labels Mar 7, 2016

mkordas reviewed Mar 7, 2016
View reviewed changes

Testing

bcceb7f

mkordas reviewed Mar 8, 2016
View reviewed changes

alex-palevsky added postponed labels Mar 10, 2016

original-brownbear reviewed Mar 10, 2016
View reviewed changes

Sebin George added 2 commits March 11, 2016 09:24

Adding another puzzle.

038e253

MultilineJavadocTagsCheck

929e881

sebing closed this Mar 11, 2016

mkordas mentioned this pull request Mar 19, 2016

#1053: Add a deprecation notice if the default docker image is used #1062

Closed

Fixing: Deprecate Using the yegor256/rultor Docker Image #1045

Fixing: Deprecate Using the yegor256/rultor Docker Image #1045

Conversation

sebing commented Mar 7, 2016

alex-palevsky commented Mar 7, 2016

original-brownbear commented Mar 7, 2016

alex-palevsky commented Mar 7, 2016

mkordas commented Mar 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkordas commented Mar 7, 2016

mkordas commented Mar 7, 2016

mkordas commented Mar 8, 2016

sebing commented Mar 8, 2016

sebing commented Mar 8, 2016

Choose a reason for hiding this comment

mkordas commented Mar 10, 2016

mkordas commented Mar 10, 2016

original-brownbear commented Mar 10, 2016

mkordas commented Mar 10, 2016

mkordas commented Mar 10, 2016

rultor commented Mar 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

original-brownbear commented Mar 10, 2016

sebing commented Mar 11, 2016

mkordas commented Mar 11, 2016

mkordas commented Mar 11, 2016

rultor commented Mar 11, 2016

original-brownbear commented Mar 11, 2016

rultor commented Mar 11, 2016

rultor commented Mar 11, 2016

mkordas commented Mar 11, 2016

sebing commented Mar 11, 2016

mkordas commented Mar 11, 2016

mkordas commented Mar 11, 2016

rultor commented Mar 11, 2016

original-brownbear commented Mar 11, 2016

rultor commented Mar 11, 2016

rultor commented Mar 11, 2016

alex-palevsky commented Mar 13, 2016