-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1039 Use merged and validated of version .rultor.yml
for merge
command.
#1070
Conversation
@xupyprmv while I just give this a quick read to be safe :) |
new TalkIssues(Profiles.github(), xml).get().repo() | ||
); | ||
profile = this.merged( | ||
master, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xupyprmv the variable master
is redundant here, please inline this real quick :)
@xupyprmv found one small thing, not sure if this was in the other PR and I just missed it (can't see it anymore now :/) or somehow new. Either way please fix it :) Thanks! |
@original-brownbear I modified PR description and fixed code. Great thanks for help. Please continue. |
@rultor merge please :) |
@xupyprmv thanks for the good job :) |
@original-brownbear OK, I'll try to merge now. You can check the progress of the merge here |
@original-brownbear Done! FYI, the full log is here (took me 17min) |
@rultor deploy |
@original-brownbear OK, I'll try to deploy now. You can check the progress here |
@original-brownbear Done! FYI, the full log is here (took me 7min) |
#1039 I implemented validated method, that checks that merged .rultor.yml has no changes in architect and commander sections. I covered
validated
method by unit tests. I added one puzzle (to implementmerged
method, write IT forvalidated
method and use it.This is a copy of #1064 that cannot be reopened. That's why I created new one.