Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodblocal.port not read #424

Closed
piotrkot opened this issue Nov 4, 2014 · 10 comments
Closed

dynamodblocal.port not read #424

piotrkot opened this issue Nov 4, 2014 · 10 comments

Comments

@piotrkot
Copy link
Contributor

piotrkot commented Nov 4, 2014

When running test DyBaseITCase, line dynamo/DyBaseITCase.java:81, throws NumberFormatException and presumably is incorrectly reading property dynamodblocal.port.
When the property is set explicitly (and dynamoDbLocal is running on the right port) NumberFormatException is not thrown.

This can also be I am running tests with dynamoDbLocal improperly. If so, please advise.

@davvd
Copy link
Collaborator

davvd commented Nov 5, 2014

this task will get someone's attention soon

@davvd
Copy link
Collaborator

davvd commented Nov 5, 2014

many thanks for the report, I topped your account for 15 mins, transaction AP-0H873291CJ6096327

@davvd
Copy link
Collaborator

davvd commented Nov 5, 2014

@krzyk it's yours, please help

@krzyk
Copy link
Contributor

krzyk commented Nov 5, 2014

@piotrkot Does it happen with some code changes on your side? When I remove @Ignore and just call

            new DyBase(DyBaseITCase.region())
                .repos().add("test").tasks();

Inside this method the code runs correctly without any exception.

@piotrkot
Copy link
Contributor Author

piotrkot commented Nov 5, 2014

@krzyk No changes on my side. Running

    @Test
    public void canAddCommand() throws Exception {
        new DyBase(DyBaseITCase.region())
                .repos().add("test").tasks();
    }

with mvn -Dtest=DyBaseITCase test gives me

Running dynamo.DyBaseITCase
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.655 sec <<< FAILURE! - in dynamo.DyBaseITCase
canAddCommand(dynamo.DyBaseITCase)  Time elapsed: 0.655 sec  <<< ERROR!
java.lang.NumberFormatException: null
        at java.lang.Integer.parseInt(Integer.java:454)
        at java.lang.Integer.parseInt(Integer.java:527)
        at dynamo.DyBaseITCase.region(DyBaseITCase.java:64)
        at dynamo.DyBaseITCase.canAddCommand(DyBaseITCase.java:55)

For the records:

Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00)
Java version: 1.7.0_65, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-39-generic", arch: "amd64", family: "unix"

@krzyk
Copy link
Contributor

krzyk commented Nov 6, 2014

@piotrkot To run failsafe tests (integration tests) you have to use:

mvn -Dit.test= DyBaseITCaseverify

@piotrkot
Copy link
Contributor Author

piotrkot commented Nov 6, 2014

@krzyk Additionally I had to install openssh-server. But now it works as it should. Thank you!

@krzyk
Copy link
Contributor

krzyk commented Nov 6, 2014

@piotrkot great, please close this issue

@piotrkot
Copy link
Contributor Author

piotrkot commented Nov 6, 2014

@krzyk Additionally I had to install openssh-server. But now it works as it should. Thank you!

@piotrkot piotrkot closed this as completed Nov 6, 2014
@davvd
Copy link
Collaborator

davvd commented Nov 7, 2014

@krzyk 30 mins sent to your balance (ID 47149061), many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants