Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DyBaseITCase.java:53-54: Add definition of tasks table... #419

Closed
davvd opened this issue Nov 4, 2014 · 30 comments
Closed

DyBaseITCase.java:53-54: Add definition of tasks table... #419

davvd opened this issue Nov 4, 2014 · 30 comments
Labels

Comments

@davvd
Copy link
Collaborator

davvd commented Nov 4, 2014

Puzzle 341-c00e1503 in src/test/java/dynamo/DyBaseITCase.java:53-54 has to be resolved: Add definition of tasks table to dynamoDb local and remove Ignore annotation.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Collaborator Author

davvd commented Nov 4, 2014

@piotrkot this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here

The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@piotrkot
Copy link
Contributor

piotrkot commented Nov 4, 2014

@davvd Could you please shed some light on the task. I am a bit confused. What is that dynamoDb local?

@piotrkot
Copy link
Contributor

piotrkot commented Nov 4, 2014

@davvd OK, little by little I am getting familiar with the project.. By DynamoDb local, do you mean just changes to the repos.json?
How can I test the DyBaseITCase from maven? I have problems setting the dynamo.port.

I am sorry for perhaps silly questions but this is my very first time with the project.

@yegor256
Copy link
Owner

yegor256 commented Nov 4, 2014

@piotrkot the best way to ask questions is by submitting new issues to the project. In this issue you will get very little support. See http://www.yegor256.com/2014/04/13/bugs-are-welcome.html

@piotrkot
Copy link
Contributor

piotrkot commented Nov 4, 2014

@yegor256 OK, submitted as suggested.
Anyway, with dynamo.port set properly, running the test results in UnsupportedOperation - which is, sort of, expected and can be fixed by me - but the task is to "add definition of tasks table". And this is I honestly do not understand.

@piotrkot
Copy link
Contributor

piotrkot commented Nov 5, 2014

@davvd OK, I see answering my, sorry for that, basic questions is a problem. How about a simple yes/no answers?
1 - "removing Ignore annotation" is a change in the code which makes the test fail. Should I make the test pass?
2 - making the test pass IMHO requires (at least) implementing com.thindeck.dynamo.DyTasks#add which requires creating DyItem class and maybe more. Is it estimated for 30min?
3 - adding a table to local instance of dynamoDB is a local change and will not be committed. Is this really required?

@yegor256
Copy link
Owner

yegor256 commented Nov 5, 2014

  1. When you remove @Ignore annotation the test should pass, of course. You can't merge anything back to master unless all tests pass.
  2. Yes, the task budget is 30 mins. You can use PDD, if the amount of work required is bigger: http://www.yegor256.com/2009/03/04/pdd.html
  3. I didn't understand the question

@piotrkot
Copy link
Contributor

piotrkot commented Nov 6, 2014

@davvd Due to issues #428 and #424, I am blocked on this task.

@yegor256
Copy link
Owner

yegor256 commented Nov 6, 2014

@davvd we're waiting for #428 here

@yegor256
Copy link
Owner

yegor256 commented Nov 6, 2014

@davvd and also waiting for #424

@davvd
Copy link
Collaborator Author

davvd commented Nov 6, 2014

@davvd we're waiting for #428 here

@yegor256 yep, got it, let's wait for #428 being solved

@davvd
Copy link
Collaborator Author

davvd commented Nov 6, 2014

@davvd and also waiting for #424

@yegor256 yes, right, let's wait for #424

@davvd
Copy link
Collaborator Author

davvd commented Nov 6, 2014

FYI, issue #424 is already closed, and we were waiting for it..

@davvd
Copy link
Collaborator Author

davvd commented Nov 6, 2014

we waited for #428, it is closed already

@piotrkot
Copy link
Contributor

@davvd I think my job is done on this one. If it is so, please close the issue.

@davvd
Copy link
Collaborator Author

davvd commented Nov 17, 2014

@piotrkot the task is your hands for the last 11 days.. keep in mind that if it's not closed in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle

@piotrkot
Copy link
Contributor

@davvd I already finished the task and it was successfully merged (#435). Is there anything else I should do?

@yegor256
Copy link
Owner

@piotrkot you're all good, just wait a bit

@davvd
Copy link
Collaborator Author

davvd commented Nov 19, 2014

The task description has been changed (see above). If there are concerns or objections, please give them to me right now. If not, please use the new version of the task description

@piotrkot
Copy link
Contributor

@davvd I am sorry I cannot see the changes. There is no puzzle at src/test/java/dynamo/DyBaseITCase.java:53-54 any more.

@yegor256
Copy link
Owner

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Nov 21, 2014

@rultor deploy

@yegor256 OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 21, 2014

@rultor deploy

@yegor256 Oops, I failed. You can see the full log here (spent 9min)

@yegor256
Copy link
Owner

@rultor try to deploy again

@rultor
Copy link
Collaborator

rultor commented Nov 21, 2014

@rultor try to deploy again

@yegor256 OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 21, 2014

@rultor try to deploy again

@yegor256 Done! FYI, the full log is here (took me 11min)

@yegor256
Copy link
Owner

@piotrkot the problem was that we didn't have an updated list of puzzles. now everything is fine, the task will be closed very soon. thanks for keeping eye on this!

@piotrkot
Copy link
Contributor

@yegor256 No problem @davvd Please, close the task, then.

@davvd
Copy link
Collaborator Author

davvd commented Nov 24, 2014

Thanks, closing it now.

@davvd davvd closed this as completed Nov 24, 2014
@davvd
Copy link
Collaborator Author

davvd commented Nov 24, 2014

@piotrkot Much appreciated! 30 mins was added to your account, payment ID AP-48F915968F397581C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants